* In-depth update of chrome->chromium, thanks to Ayutac, Xanthian
This fixes Bug #2621 without accidentally destroying items (untested, but the chrome item registration isn't changed) and supersedes PR #2780 which only made language changes.
I just plainly copied the lang changes from Xanthian. As for the chrome stuff, I thought long and hard how to do it properly. Possible variants:
1. Change tag names in constructor for chrome only.
2. Change tag names in enum for chrome only.
3. Don't change the internal tag names of the enums, but change the tag registration process in datagen for chrome only.
4. Introduce CHROMIUM variant, add conversion recipes etc. and hope over time CHROME can be safely removed.
(4) always had the potential of item loss, so I discarded it first. Deciding between (1), (2) and (3) was harder. The drawback of (2) is code bloating by adding a lot of extra enum constructors, especially for cases which already had enum constructor options. But in the end I decided to go with it because it was the cleanest solution to a dirty problem. This is the first time I encountered a datagen drawback, because if we didn't register by running through the enum array, we could have simply changed it there; a possible (5) but still worse than (2).
* Whoops, forgot recipe changes with the tags
* Merged chromium with hardness/resistance
Replaced the isHot argument from constructors with default false while I was at it.
Changes primary output to 2x raw iridium as other recipes that use mercury with this machine generally have a greater output than just with water.
Makes more sense to have the raw ore as the output from this machine instead of an ingot, which you would usually get from a furnace of some type.
* Fixes#2783 hopefully
Needs to be tested still. Goal: changed blasting to use half as much as time as regular furnace for same item.
* Fixed bug in commit thanks to ErrorSys
forgot that order of optional arguments is important and that int can be cast to float automatically
I increased the capacity of tanks to be even remotely considered an alternative to storage units with cells. I kept the values conservative since increasing is always an option, but decreasing might cause item loss.
Changes:
Basic Tank: 35 -> 128 (about 3.5 times)
Advanced Tank: 200 -> 512 (about 2.5 times)
Industrial Tank: 500 -> 1024 (about 2 times)
I oriented myself at the storage unit steps, which are quadrupled with each tier until advanced, then doubled to industrial.
While I was at it, I changed everything to powers of 2 with the shift operator (so other code readers aren't too confused about seemingly arbitrary values) and added explaining comments.
* fix naming in ModelSantaHat.java
* Fix grammar, spelling, and javadocs in RebornCore
* Fix spelling error in datagen
* fix missed variable name
* fix grammar, spelling, and javadoc errors
* fix grammar and spelling errors in project files
* specify indent_size in .editorconfig
Raw metals thought the ingot storage block variant was their variant. THIS AFFECTS STORAGE RECIPES! Effectively means 9 raw variants can be combined to one ingot storage block, so maybe quickly new beta?
* Half of 2 new blocks, other half is a lot of data/model files
* Rest of the data/asset changes for new storage blocks.
* Bugfixes
* made hot tungstensteel storage block opaque
* Small Piglin tag update
added gold plate and electrum to piglin stuff. Piglins should be able to smell the gold out of an electrum ingot and a block, but not a nugget. Baby piglins are worse at this.
Explicitly used TR IDs instead of c tags because this is part of TR flavor imo
* forgot electrum plate
* and gold cables
* Added dust crafting data gen.
Generation works, but how do I get TR to recognize the existence of the new stuff?
* Added generic armor and tools to the datagen. Also resolved conflicts from the merge with recently changed datagen
* Fixed copy-paste error
by accident for second ingredient first would be taken again
* automatized tag generation
* fixed lingering bugs from previous commit
* much much more gen, for about 269 files
* wrongly deleted recipes in last commit
* Added rest of the decorative storage block variants to datagen
If the table was locked, canMake only checked for each ingredient to be there more than once, but make greedily took all items from the first encountered slot of the needed ingredient if the recipe didn't use the full crafting table and the ingredients weren't aligned to the upper left corner of the crafting table (discovered and reproducible with three wheat in the first column second row and single wheats in the other two columns of the second row).
This commit simply disallows greedy behaviour, each crafting grid slot can only be used once.
I also made one or two changes to the rest of the code (formatting,use of constants etc) while I was at it, but these didn't change functionality.
Should default to false in old and new configs, ie no new behaviour, but now I can deactivate it via config instead of using an unofficial distribution. Will probably come back to this once the toasts are finished...
