Optimise Iron furnace recipe lookup

This commit is contained in:
modmuss50 2020-12-20 21:24:05 +00:00
parent af62a85677
commit 2ea118ec63
2 changed files with 39 additions and 16 deletions

View file

@ -30,6 +30,7 @@ import net.minecraft.entity.player.PlayerEntity;
import net.minecraft.item.ItemStack;
import net.minecraft.nbt.CompoundTag;
import net.minecraft.recipe.AbstractCookingRecipe;
import net.minecraft.recipe.Recipe;
import net.minecraft.recipe.RecipeType;
import net.minecraft.recipe.SmeltingRecipe;
import net.minecraft.server.network.ServerPlayerEntity;
@ -49,6 +50,8 @@ public class IronFurnaceBlockEntity extends AbstractIronMachineBlockEntity imple
int outputSlot = 1;
public float experience;
private Recipe<?> lastRecipe = null;
public IronFurnaceBlockEntity() {
super(TRBlockEntities.IRON_FURNACE, 2, TRContent.Machine.IRON_FURNACE.block);
this.inventory = new RebornInventory<>(3, "IronFurnaceBlockEntity", 64, this);
@ -68,10 +71,23 @@ public class IronFurnaceBlockEntity extends AbstractIronMachineBlockEntity imple
}
private ItemStack getResultFor(ItemStack stack) {
ItemStack result = RecipeUtils.getMatchingRecipes(world, RecipeType.SMELTING, stack);
if (!result.isEmpty()) {
return result.copy();
if (stack.isEmpty()) {
// Fast fail if there is no input, no point checking the recipes if the machine is empty
return ItemStack.EMPTY;
}
// Check the previous recipe to see if it still applies to the current inv, saves rechecking the whole recipe list
if (lastRecipe != null && RecipeUtils.matchesSingleInput(lastRecipe, stack)) {
return lastRecipe.getOutput();
}
Recipe<?> matchingRecipe = RecipeUtils.getMatchingRecipe(world, RecipeType.SMELTING, stack).orElse(null);
if (matchingRecipe != null) {
lastRecipe = matchingRecipe;
return matchingRecipe.getOutput().copy();
}
return ItemStack.EMPTY;
}
@ -104,17 +120,20 @@ public class IronFurnaceBlockEntity extends AbstractIronMachineBlockEntity imple
@Override
protected boolean canSmelt() {
if (inventory.getStack(inputSlot).isEmpty()) {
ItemStack inputStack = inventory.getStack(inputSlot);
if (inputStack.isEmpty())
return false;
}
ItemStack outputStack = getResultFor(inventory.getStack(inputSlot));
ItemStack outputStack = getResultFor(inputStack);
if (outputStack.isEmpty())
return false;
if (inventory.getStack(outputSlot).isEmpty())
ItemStack outputSlotStack = inventory.getStack(outputSlot);
if (outputSlotStack.isEmpty())
return true;
if (!inventory.getStack(outputSlot).isItemEqualIgnoreDamage(outputStack))
if (!outputSlotStack.isItemEqualIgnoreDamage(outputStack))
return false;
int result = inventory.getStack(outputSlot).getCount() + outputStack.getCount();
int result = outputSlotStack.getCount() + outputStack.getCount();
return result <= inventory.getStackLimit() && result <= outputStack.getMaxCount();
}

View file

@ -32,22 +32,26 @@ import techreborn.items.DynamicCellItem;
import org.jetbrains.annotations.NotNull;
import java.util.List;
import java.util.Optional;
import java.util.stream.Collectors;
public class RecipeUtils {
@NotNull
public static ItemStack getEmptyCell(int stackSize) {
return DynamicCellItem.getEmptyCell(stackSize);
public static <T extends Recipe<?>> Optional<Recipe<?>> getMatchingRecipe(World world, RecipeType<T> type, ItemStack input) {
return getRecipes(world, type).stream()
.filter(recipe -> matchesSingleInput(recipe, input))
.findFirst();
}
public static boolean matchesSingleInput(Recipe<?> recipe, ItemStack input) {
return recipe.getPreviewInputs().size() == 1 && recipe.getPreviewInputs().get(0).test(input);
}
/**
* Used to get the matching output of a recipe type that only has 1 input
*/
public static <T extends Recipe<?>> ItemStack getMatchingRecipes(World world, RecipeType<T> type, ItemStack input) {
return getRecipes(world, type).stream()
.filter(recipe -> recipe.getPreviewInputs().size() == 1 && recipe.getPreviewInputs().get(0).test(input))
public static <T extends Recipe<?>> ItemStack getMatchingRecipeOutput(World world, RecipeType<T> type, ItemStack input) {
return getMatchingRecipe(world, type, input)
.map(Recipe::getOutput)
.findFirst()
.orElse(ItemStack.EMPTY);
}