forked from NYANDEV/forgejo
88a03a6133
We need to make sure a user can't confirm the existence of a user with private visibility * Follow up on #21533 ### Before #### User  #### Admin  ### After #### User  #### Admin  Signed-off-by: Yarden Shoham <hrsi88@gmail.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
53 lines
1.9 KiB
Go
53 lines
1.9 KiB
Go
// Copyright 2022 The Gitea Authors. All rights reserved.
|
|
// Use of this source code is governed by a MIT-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package markup
|
|
|
|
import (
|
|
"context"
|
|
"net/http"
|
|
"testing"
|
|
|
|
"code.gitea.io/gitea/models/db"
|
|
"code.gitea.io/gitea/models/unittest"
|
|
"code.gitea.io/gitea/models/user"
|
|
gitea_context "code.gitea.io/gitea/modules/context"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestProcessorHelper(t *testing.T) {
|
|
assert.NoError(t, unittest.PrepareTestDatabase())
|
|
|
|
userPublic := "user1"
|
|
userPrivate := "user31"
|
|
userLimited := "user33"
|
|
userNoSuch := "no-such-user"
|
|
|
|
unittest.AssertCount(t, &user.User{Name: userPublic}, 1)
|
|
unittest.AssertCount(t, &user.User{Name: userPrivate}, 1)
|
|
unittest.AssertCount(t, &user.User{Name: userLimited}, 1)
|
|
unittest.AssertCount(t, &user.User{Name: userNoSuch}, 0)
|
|
|
|
// when using general context, use user's visibility to check
|
|
assert.True(t, ProcessorHelper().IsUsernameMentionable(context.Background(), userPublic))
|
|
assert.False(t, ProcessorHelper().IsUsernameMentionable(context.Background(), userLimited))
|
|
assert.False(t, ProcessorHelper().IsUsernameMentionable(context.Background(), userPrivate))
|
|
assert.False(t, ProcessorHelper().IsUsernameMentionable(context.Background(), userNoSuch))
|
|
|
|
// when using web context, use user.IsUserVisibleToViewer to check
|
|
var err error
|
|
giteaCtx := &gitea_context.Context{}
|
|
giteaCtx.Req, err = http.NewRequest("GET", "/", nil)
|
|
assert.NoError(t, err)
|
|
|
|
giteaCtx.Doer = nil
|
|
assert.True(t, ProcessorHelper().IsUsernameMentionable(giteaCtx, userPublic))
|
|
assert.False(t, ProcessorHelper().IsUsernameMentionable(giteaCtx, userPrivate))
|
|
|
|
giteaCtx.Doer, err = user.GetUserByName(db.DefaultContext, userPrivate)
|
|
assert.NoError(t, err)
|
|
assert.True(t, ProcessorHelper().IsUsernameMentionable(giteaCtx, userPublic))
|
|
assert.True(t, ProcessorHelper().IsUsernameMentionable(giteaCtx, userPrivate))
|
|
}
|