1
0
Fork 0
forked from NYANDEV/forgejo
forgejo/routers
SteveTheEngineer 764e75d9b9
Catch the error before the response is processed by goth. () ()
The code introduced by  gets the error from response after it was processed by goth.

That is incorrect, as goth (and golang.org/x/oauth) doesn't really care about the error, and it sends a token request with an empty authorization code to the server anyway, which always results in a `oauth2: cannot fetch token: 400 Bad Request` error from goth.
It means that unless the "state" parameter is omitted from the error response (which is required to be present, according to [RFC 6749, Section 4.1.2.1](https://datatracker.ietf.org/doc/html/rfc6749#section-4.1.2.1)) or the page is reloaded (makes the session invalid), a 500 Internal Server Error page will be displayed.
This fixes it by handling the error before the request is passed to goth.
2022-06-24 10:05:23 +08:00
..
api fix permission check for delete tag () 2022-06-16 22:03:03 +02:00
common Fix raw endpoint PDF file headers () 2022-05-28 18:10:14 +03:00
install feat: add DEFAULT_MERGE_STYLE to repository.pull-request section for repo init () 2022-06-02 23:45:54 -04:00
private move agit dependcy () 2022-06-17 20:17:12 +02:00
utils A better go code formatter, and now make fmt can run in Windows () 2021-11-17 20:34:35 +08:00
web Catch the error before the response is processed by goth. () () 2022-06-24 10:05:23 +08:00
init.go Fix data-race problems in git module (quick patch) () 2022-06-11 11:56:27 +08:00