femsci/forgejo
femsci/forgejo
1
0
Fork 0
forked from NYANDEV/forgejo
Code Pull requests Activity
forgejo/web_src/css
History
Hester Gong 476a043a5f
Refactor delete_modal_actions template and use it for project column related actions (#24097) 
Co-Author: @wxiaoguang 

This PR is to fix
https://github.com/go-gitea/gitea/issues/23318#issuecomment-1506275446 .
The way to fix this in this PR is to use `delete_modal_actions.tmpl`
here both to fix this issue and keep ui consistency (as suggested by
[TODO
here](4299c3b7db/templates/projects/view.tmpl (L161)))

And this PR also refactors `delete_modal_actions.tmpl` and its related
styles, and use the template for more modal actions:

1. Added template attributes:
* locale
* ModalButtonStyle: "yes" (default) or "confirm"
* ModalButtonCancelText
* ModalButtonOkText

2. Rename `delete_modal_actions.tmpl` template to
`modal_actions_confirm.tmpl` because it is not only used for action
modals deletion now.

3. Refactored css related to modals into `web_src/css/modules/modal.css`
and improved the styles.

4. Also use the template for PR deletion modal and remove issue
dependency modal.

5. Some modals should also use the template, but not sure how to open
them, so mark these modal actions by `{{/* TODO: Convert to
base/modal_actions_confirm */}}`

After (Also tested on arc green):

Hovering on the left buttons

<img width="711" alt="Screen Shot 2023-04-23 at 15 17 12"
src="https://user-images.githubusercontent.com/17645053/233825650-76307e65-9255-44bb-80e8-7062f58ead1b.png">

<img width="786" alt="Screen Shot 2023-04-23 at 15 17 21"
src="https://user-images.githubusercontent.com/17645053/233825652-4dc6f7d1-a180-49fb-a468-d60950eaee0d.png">

Test for functionalities:

https://user-images.githubusercontent.com/17645053/233826857-76376fda-022c-42d0-b0f3-339c17ca4e59.mov

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2023-04-23 17:24:19 +08:00
..
chroma Replace Less with CSS (#23481) 2023-03-14 22:20:19 -04:00
code Fix some broken css (#23560) 2023-03-18 17:53:12 -04:00
codemirror Replace Less with CSS (#23481) 2023-03-14 22:20:19 -04:00
console Replace Less with CSS (#23481) 2023-03-14 22:20:19 -04:00
features Fix issue attachment handling (#24202) 2023-04-20 02:39:44 -04:00
markup Fix math and mermaid rendering bugs (#24049) 2023-04-17 12:10:22 +02:00
modules Refactor delete_modal_actions template and use it for project column related actions (#24097) 2023-04-23 17:24:19 +08:00
shared Use secondary pointing menu for tabs on user/organization home page (#24162) 2023-04-20 04:58:26 -04:00
standalone Replace Less with CSS (#23481) 2023-03-14 22:20:19 -04:00
themes CSS color tweaks (#23828) 2023-03-31 16:24:47 +08:00
admin.css Replace Less with CSS (#23481) 2023-03-14 22:20:19 -04:00
animations.css Replace Less with CSS (#23481) 2023-03-14 22:20:19 -04:00
base.css Refactor delete_modal_actions template and use it for project column related actions (#24097) 2023-04-23 17:24:19 +08:00
dashboard.css Vertical widths of containers removed (#24184) 2023-04-19 12:13:00 -04:00
editor-markdown.css Set EasyMDE heading font-size to the same size as the resulting markdown (#24151) 2023-04-16 20:01:08 +08:00
editor.css Introduce GitHub markdown editor, keep EasyMDE as fallback (#23876) 2023-04-03 18:06:57 +08:00
explore.css Fix long name ui issues and label ui issue (#23541) 2023-03-18 17:07:59 +01:00
font_i18n.css Replace Less with CSS (#23481) 2023-03-14 22:20:19 -04:00
form.css Replace tribute with text-expander-element for textarea (#23985) 2023-04-09 12:18:45 -04:00
helpers.css Fix math and mermaid rendering bugs (#24049) 2023-04-17 12:10:22 +02:00
home.css Fix footer display (#24251) 2023-04-22 01:58:59 -04:00
index.css Refactor delete_modal_actions template and use it for project column related actions (#24097) 2023-04-23 17:24:19 +08:00
install.css Replace Less with CSS (#23481) 2023-03-14 22:20:19 -04:00
organization.css Use secondary pointing menu for tabs on user/organization home page (#24162) 2023-04-20 04:58:26 -04:00
package.css Replace Less with CSS (#23481) 2023-03-14 22:20:19 -04:00
repository.css Use secondary pointing menu for tabs on user/organization home page (#24162) 2023-04-20 04:58:26 -04:00
review.css Expand/Collapse all changed files (#23639) 2023-04-09 21:11:02 +08:00
runner.css Replace Less with CSS (#23481) 2023-03-14 22:20:19 -04:00
svg.css Replace Less with CSS (#23481) 2023-03-14 22:20:19 -04:00
tribute.css Replace Less with CSS (#23481) 2023-03-14 22:20:19 -04:00
user.css Fix user profile description rendering (#23882) 2023-04-03 16:11:16 -04:00