forgejo/services
Gergely Nagy 439fadf563
[GITEA] services: Gracefully handle missing branches
services: in loadOneBranch, return if CountDivergingCommits fail

If we can't count the number of diverging commits for one reason or
another (such as the branch being in the database, but missing from
disk), rather than logging an error and continuing into a crash (because
`divergence` will be nil), return an error instead.

Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>
(cherry picked from commit 8266105f24eb76b1dfb4c79d9bfde2ef9a98417a)

services: Gracefully handle missing branches

When loading branches, if loading one fails, log an error, and ignore
the branch, rather than returning and causing an internal server error.

Ideally, we would only ignore the error if it was caused by a missing
branch, and do it silently, like the respective API endpoint does.
However, veryfing that at this place is not very practical, so for the
time being, ignore any and all branch loading errors.

Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>
(cherry picked from commit e552a8fd629b11503569f605c824c1c0b01eeab2)

tests: Add a testcase for missing branches

This tests the scenario reported in Codeberg/Community#1408: a branch
that is recorded in the database, but missing on disk was causing
internal server errors. With recent changes, that is no longer the case,
the error is logged and then ignored.

This test case tests this behaviour, that the repo's branches page on
the web UI functions even if the git branch is missing.

Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>
(cherry picked from commit e20eb7b3853e25ab29d4ca63b015517b44e4954f)

tests: More testing in TestDatabaseMissingABranch

In the `TestDatabaseMissingABranch` testcase, make sure that the
branches are in sync between the db and git before deleting a branch via
git, then compare the branch count from the web UI, making sure that it
returns an out-of-sync value first, and the correct one after another
sync.

This is currently tested by scraping the UI, and relies on the fact that
the branch counter is out of date before syncing. If that issue gets
resolved, we'll have to adjust the test to verify the sync another way.

Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>
(cherry picked from commit 8c2ccfcecec6182dd80d463f58223acbf16b039b)
2024-01-15 16:51:45 +00:00
..
actions [ACTIONS] on.schedule: create a new payload 2024-01-15 16:47:17 +00:00
agit Adjust object format interface (#28469) 2023-12-17 11:56:08 +00:00
asymkey Move more functions to db.Find (#28419) 2024-01-15 02:19:25 +00:00
attachment [FEAT] allow setting the update date on issues and comments 2024-01-15 14:48:04 +00:00
auth [SECURITY] Rework long-term authentication 2024-01-15 14:48:04 +00:00
automerge Improve queue and logger context (#24924) 2023-05-26 07:31:55 +00:00
context Another round of db.DefaultContext refactor (#27103) 2023-09-25 13:17:37 +00:00
convert [GITEA] POST /repos/{owner}/{repo}/pulls/{index}/reviews/{id}/comments 2024-01-15 16:51:45 +00:00
cron Update go dependencies (#28518) 2023-12-19 09:18:42 +08:00
externalaccount Final round of db.DefaultContext refactor (#27587) 2023-10-14 08:37:24 +00:00
feed More db.DefaultContext refactor (#27265) 2023-09-29 12:12:54 +00:00
forgejo [UPGRADE] run sanity checks before the database is upgraded 2024-01-15 14:48:04 +00:00
forms [GITEA] Optionally allow anyone to edit Wikis 2024-01-15 16:48:44 +00:00
gitdiff Add option to disable ambiguous unicode characters detection (#28454) 2023-12-17 14:38:54 +00:00
indexer Fix missing issue search index update when changing status (#28325) 2023-12-03 12:22:44 +01:00
issue [FEAT] allow setting the update date on issues and comments 2024-01-15 14:48:04 +00:00
lfs [GITEA] Drop sha256-simd in favor of stdlib 2024-01-15 16:11:57 +00:00
mailer [GITEA] notifies admins on new user registration (squash) DeleteByID 2024-01-15 16:48:45 +00:00
markup make writing main test easier (#27270) 2023-09-28 01:38:53 +00:00
migrations [GITEA] Avoid conflicts of issue and PR numbers in GitLab migration (#1790) 2024-01-15 16:11:58 +00:00
mirror Refactor deletion (#28610) 2023-12-25 21:25:29 +01:00
notify [GITEA] notifies admins on new user registration 2024-01-15 16:11:57 +00:00
org Delete repos of org when purge delete user (#27273) 2023-10-19 13:16:11 +00:00
packages Support for grouping RPMs using paths (#26984) 2024-01-12 03:16:05 +00:00
pull [GITEA] Use existing error functionality 2024-01-15 16:11:58 +00:00
release Refactor deletion (#28610) 2023-12-25 21:25:29 +01:00
repository [GITEA] services: Gracefully handle missing branches 2024-01-15 16:51:45 +00:00
secrets Refactor deletion (#28610) 2023-12-25 21:25:29 +01:00
task Fix incorrect ctx usage in defer function (#27740) 2023-10-22 14:12:27 +00:00
uinotification Penultimate round of db.DefaultContext refactor (#27414) 2023-10-11 04:24:07 +00:00
user Forbid removing the last admin user (#28337) 2024-01-15 06:51:43 +00:00
webhook [GITEA] Drop sha256-simd in favor of stdlib 2024-01-15 16:11:57 +00:00
wiki Fix schedule tasks bugs (#28691) 2024-01-12 21:50:38 +00:00