Commit graph

5 commits

Author SHA1 Message Date
Earl Warren
75cb7286ae
[CI] disable minio test, no minio server yet in CI
(cherry picked from commit 0dd74d09d363433b1b8730bd26a6d7865e1e5ca0)
(cherry picked from commit 28d2d9b212e168fcc56a280c5750716e70a75f8d)
(cherry picked from commit 3c3db1ff0f5f7d2490895a64498446f41ac6c30c)
(cherry picked from commit 79bbbe2dd2)
(cherry picked from commit a4050eb6b1769c60de80090d58c852b5cf05109b)
(cherry picked from commit d8fac17bbe3bbe69745d1c6abaa3678d3378df73)
(cherry picked from commit 1220a8e0158a06e6652f09c23c17c1e3e4834e7d)
(cherry picked from commit 61562598d55dcf788e7b496c696d5cd5d0b1ed99)
(cherry picked from commit c42ffe52136d59849eec26d25f7040064582d76e)
(cherry picked from commit 3f0d1622b6c059c9c189b9cad6f29ea9ff0aefe9)
2023-07-16 23:21:44 +02:00
Giteabot
21cd5c2f3d
Fix all possible setting error related storages and added some tests (#23911) (#25244)
Backport #23911 by @lunny

Follow up #22405

Fix #20703 

This PR rewrites storage configuration read sequences with some breaks
and tests. It becomes more strict than before and also fixed some
inherit problems.

- Move storage's MinioConfig struct into setting, so after the
configuration loading, the values will be stored into the struct but not
still on some section.
- All storages configurations should be stored on one section,
configuration items cannot be overrided by multiple sections. The
prioioty of configuration is `[attachment]` > `[storage.attachments]` |
`[storage.customized]` > `[storage]` > `default`
- For extra override configuration items, currently are `SERVE_DIRECT`,
`MINIO_BASE_PATH`, `MINIO_BUCKET`, which could be configured in another
section. The prioioty of the override configuration is `[attachment]` >
`[storage.attachments]` > `default`.
- Add more tests for storages configurations.
- Update the storage documentations.

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2023-06-14 08:36:52 +02:00
silverwind
655c890cbd
Fix TestMinioStorageIterator skip message (#24765)
Followup to https://github.com/go-gitea/gitea/pull/24762, fix this
message.
2023-05-17 16:22:17 +00:00
Lunny Xiao
6c8235dc98
Skip TestMinioStorageIterator on CI (#24762)
Fix https://github.com/go-gitea/gitea/pull/24691#issuecomment-1550987681

---------

Co-authored-by: silverwind <me@silverwind.io>
2023-05-17 10:00:58 +00:00
FuXiaoHei
61ad4c607b
fix minio storage iterator path (#24691)
minio storage iterator shows different behavior with local fs iterator.

in local fs storage:

``` go
s.IterateObjects("prefix", func(path,obj)
     println(path) // show "prefix/xxx.file"
})
```

in minio storage:

```go
s.IterateObjects("prefix", func(path,obj)
     println(path) // show "xxx.file"
})
```

I think local fs is correct, minio use wrong `basePath` to trim storage
path prefix.

---------

Co-authored-by: Giteabot <teabot@gitea.io>
2023-05-13 22:33:25 +00:00