Backport emoji fixes to 1.12 (#12327)

* Fix emoji detection in certain cases (#12320)

* Fix emoji detection certain cases

Previous tests weren't complicated enough so there were some situations where emojis were't detected properly. Find the earliest occurance in addition to checking for the longest combination.

Fixes #12312

* ok spell bot

Co-authored-by: Lauris BH <lauris@nix.lv>

* Reduce emoji size (#12317)

* Reduce emoji size

Rendering should now pretty much match GitHub with 1.25em. I verified
that emojis don't increase the line height and removed unecessary size
overrides because now all emojis should appear similar in relation to
the font size.

* fix reaction hover

Co-authored-by: mrsdizzie <info@mrsdizzie.com>
Co-authored-by: Lauris BH <lauris@nix.lv>
This commit is contained in:
silverwind 2020-07-25 18:50:57 +02:00 committed by GitHub
parent 8d1cd4d252
commit ad68c9ccb2
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 27 additions and 21 deletions

View file

@ -1271,33 +1271,18 @@ i.icon.centerlock {
.emoji,
.reaction {
font-size: 1.5em;
line-height: 1.2;
font-size: 1.25em;
line-height: 1;
font-style: normal !important;
font-weight: normal !important;
vertical-align: middle;
vertical-align: -.075em;
}
#issue-title > .emoji {
font-size: 1em;
}
.commit-summary > .emoji {
font-size: 1em;
}
.label > .emoji {
font-size: 1em;
}
.dropdown .emoji {
font-size: 1em;
}
.emoji img,
.reaction img {
border-width: 0 !important;
margin: 0 !important;
width: 1em !important;
height: 1em !important;
vertical-align: middle !important;
vertical-align: -.15em;
}