forked from NYANDEV/forgejo
Ignore temporary files for directory size
- Backport https://codeberg.org/forgejo/forgejo/pulls/1742
- While looking trough the logs for unrelated things I noticed errors
for directory size calculations in `pushUpdates` that were being caused
by a race condition in which git was making temporary file,
`filepath.WalkDir` noticed that but by the time the second lstat
came(`info.Info()`) it was already gone and it would error.
- Ignore temporary files created by Git.
- There are other cases but much much more rarer and not trivial to detect.
Examples:
...s/repository/push.go:96:pushUpdates() [E] Failed to update size for repository: updateSize: lstat [...]/objects/info/commit-graphs/tmp_graph_Wcy9kR: no such file or directory
...s/repository/push.go:96:pushUpdates() [E] Failed to update size for repository: updateSize: lstat [...]/packed-refs.lock: no such file or directory
(cherry picked from commit 16ce00772d
)
This commit is contained in:
parent
2f6329f693
commit
2aebef847f
1 changed files with 5 additions and 1 deletions
|
@ -167,7 +167,11 @@ func getDirectorySize(path string) (int64, error) {
|
|||
}
|
||||
return err
|
||||
}
|
||||
if info.IsDir() {
|
||||
|
||||
fileName := info.Name()
|
||||
// Ignore temporary Git files as they will like be missing once info.Info is
|
||||
// called and cause a disrupt to the whole operation.
|
||||
if info.IsDir() || strings.HasSuffix(fileName, ".lock") || strings.HasPrefix(filepath.Base(fileName), "tmp_graph") {
|
||||
return nil
|
||||
}
|
||||
f, err := info.Info()
|
||||
|
|
Loading…
Reference in a new issue