femsci/forgejo
femsci/forgejo
1
0
Fork 0
forked from NYANDEV/forgejo
Code Pull requests Activity

Remove deprecated query condition in ListReleases (#28339)

Browse source 
close #24057 
call stack: 

25faee3c5f/routers/api/v1/repo/release.go (L154)

ec1feedbf5/routers/api/v1/utils/page.go (L13-L18)

ec1feedbf5/services/convert/utils.go (L15-L22)

## ⚠️ Breaking   ⚠️ (though it's not caused by this PR)
Do not use `per_page` to specify pagination; use `limit` instead
This commit is contained in:
Nanguan Lin 2023-12-05 15:30:43 +08:00 committed by GitHub
parent 38a93a0665
commit 0aab2d38a7
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 0 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
routers/api/v1/repo/release.go
View file

@ -133,11 +133,6 @@ func ListReleases(ctx *context.APIContext) {
// in: query // in: query
// description: filter (exclude / include) pre-releases // description: filter (exclude / include) pre-releases
// type: boolean // type: boolean
// - name: per_page
// in: query
// description: page size of results, deprecated - use limit
// type: integer
// deprecated: true
// - name: page // - name: page
// in: query // in: query
// description: page number of results to return (1-based) // description: page number of results to return (1-based)
@ -152,9 +147,6 @@ func ListReleases(ctx *context.APIContext) {
// "404": // "404":
// "$ref": "#/responses/notFound" // "$ref": "#/responses/notFound"
listOptions := utils.GetListOptions(ctx) listOptions := utils.GetListOptions(ctx)
if listOptions.PageSize == 0 && ctx.FormInt("per_page") != 0 {
listOptions.PageSize = ctx.FormInt("per_page")
}
opts := repo_model.FindReleasesOptions{ opts := repo_model.FindReleasesOptions{
ListOptions: listOptions, ListOptions: listOptions,

6
templates/swagger/v1_json.tmpl generated
View file

@ -11728,12 +11728,6 @@
"name": "pre-release", "name": "pre-release",
"in": "query" "in": "query"
}, },
{
"type": "integer",
"description": "page size of results, deprecated - use limit",
"name": "per_page",
"in": "query"
},
{ {
"type": "integer", "type": "integer",
"description": "page number of results to return (1-based)", "description": "page number of results to return (1-based)",