mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2025-03-12 00:12:37 +01:00
- The security patch of forgejo/forgejo#6843 fixed the issue where project boards loaded all issues without considering if the doer actually had permission to view that issue. Within that patch the call to `Issues` was modified to include this permission checking. - The query being generated was not entirely correct. Issues in public repositories weren't considered correctly (partly the fault of not setting `AllPublic` unconditionally) in the cause an authenticated user loaded the project. - This is now fixed by setting `AllPublic` unconditionally and subsequently fixing the `Issue` function to ensure that the combination of setting `AllPublic` and `User` generates the correct query, by combining the permission check and issues in public repositories as one `AND` query. - Added unit testing. - Added integration testing. - Resolves Codeberg/Community#1809 - Regression of https://codeberg.org/forgejo/forgejo/pulls/6843 Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/7143 Reviewed-by: Otto <otto@codeberg.org> Co-authored-by: Gusted <postmaster@gusted.xyz> Co-committed-by: Gusted <postmaster@gusted.xyz>
119 lines
4.7 KiB
Go
119 lines
4.7 KiB
Go
// Copyright 2025 The Forgejo Authors. All rights reserved.
|
|
// SPDX-License-Identifier: GPL-3.0-or-later
|
|
|
|
package issues_test
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"code.gitea.io/gitea/models/db"
|
|
"code.gitea.io/gitea/models/issues"
|
|
"code.gitea.io/gitea/models/organization"
|
|
"code.gitea.io/gitea/models/project"
|
|
"code.gitea.io/gitea/models/unittest"
|
|
user_model "code.gitea.io/gitea/models/user"
|
|
"code.gitea.io/gitea/modules/optional"
|
|
"code.gitea.io/gitea/tests"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestPrivateIssueProjects(t *testing.T) {
|
|
defer tests.AddFixtures("models/fixtures/PrivateIssueProjects/")()
|
|
require.NoError(t, unittest.PrepareTestDatabase())
|
|
|
|
user2 := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 2})
|
|
t.Run("Organization project", func(t *testing.T) {
|
|
org := unittest.AssertExistsAndLoadBean(t, &organization.Organization{ID: 3})
|
|
orgProject := unittest.AssertExistsAndLoadBean(t, &project.Project{ID: 1001, OwnerID: org.ID})
|
|
column := unittest.AssertExistsAndLoadBean(t, &project.Column{ID: 1001, ProjectID: orgProject.ID})
|
|
|
|
t.Run("Authenticated user", func(t *testing.T) {
|
|
defer tests.PrintCurrentTest(t)()
|
|
issueList, err := issues.LoadIssuesFromColumn(db.DefaultContext, column, user2, org, optional.None[bool]())
|
|
require.NoError(t, err)
|
|
assert.Len(t, issueList, 2)
|
|
assert.EqualValues(t, 16, issueList[0].ID)
|
|
assert.EqualValues(t, 6, issueList[1].ID)
|
|
|
|
issuesNum, err := issues.NumIssuesInProject(db.DefaultContext, orgProject, user2, org, optional.None[bool]())
|
|
require.NoError(t, err)
|
|
assert.EqualValues(t, 2, issuesNum)
|
|
|
|
issuesNum, err = issues.NumIssuesInProject(db.DefaultContext, orgProject, user2, org, optional.Some(true))
|
|
require.NoError(t, err)
|
|
assert.EqualValues(t, 0, issuesNum)
|
|
|
|
issuesNum, err = issues.NumIssuesInProject(db.DefaultContext, orgProject, user2, org, optional.Some(false))
|
|
require.NoError(t, err)
|
|
assert.EqualValues(t, 2, issuesNum)
|
|
})
|
|
|
|
t.Run("Anonymous user", func(t *testing.T) {
|
|
defer tests.PrintCurrentTest(t)()
|
|
issueList, err := issues.LoadIssuesFromColumn(db.DefaultContext, column, nil, org, optional.None[bool]())
|
|
require.NoError(t, err)
|
|
assert.Len(t, issueList, 1)
|
|
assert.EqualValues(t, 16, issueList[0].ID)
|
|
|
|
issuesNum, err := issues.NumIssuesInProject(db.DefaultContext, orgProject, nil, org, optional.None[bool]())
|
|
require.NoError(t, err)
|
|
assert.EqualValues(t, 1, issuesNum)
|
|
|
|
issuesNum, err = issues.NumIssuesInProject(db.DefaultContext, orgProject, nil, org, optional.Some(true))
|
|
require.NoError(t, err)
|
|
assert.EqualValues(t, 0, issuesNum)
|
|
|
|
issuesNum, err = issues.NumIssuesInProject(db.DefaultContext, orgProject, nil, org, optional.Some(false))
|
|
require.NoError(t, err)
|
|
assert.EqualValues(t, 1, issuesNum)
|
|
})
|
|
})
|
|
|
|
t.Run("User project", func(t *testing.T) {
|
|
userProject := unittest.AssertExistsAndLoadBean(t, &project.Project{ID: 1002, OwnerID: user2.ID})
|
|
column := unittest.AssertExistsAndLoadBean(t, &project.Column{ID: 1002, ProjectID: userProject.ID})
|
|
|
|
t.Run("Authenticated user", func(t *testing.T) {
|
|
defer tests.PrintCurrentTest(t)()
|
|
issueList, err := issues.LoadIssuesFromColumn(db.DefaultContext, column, user2, nil, optional.None[bool]())
|
|
require.NoError(t, err)
|
|
assert.Len(t, issueList, 2)
|
|
assert.EqualValues(t, 7, issueList[0].ID)
|
|
assert.EqualValues(t, 1, issueList[1].ID)
|
|
|
|
issuesNum, err := issues.NumIssuesInProject(db.DefaultContext, userProject, user2, nil, optional.None[bool]())
|
|
require.NoError(t, err)
|
|
assert.EqualValues(t, 2, issuesNum)
|
|
|
|
issuesNum, err = issues.NumIssuesInProject(db.DefaultContext, userProject, user2, nil, optional.Some(true))
|
|
require.NoError(t, err)
|
|
assert.EqualValues(t, 0, issuesNum)
|
|
|
|
issuesNum, err = issues.NumIssuesInProject(db.DefaultContext, userProject, user2, nil, optional.Some(false))
|
|
require.NoError(t, err)
|
|
assert.EqualValues(t, 2, issuesNum)
|
|
})
|
|
|
|
t.Run("Anonymous user", func(t *testing.T) {
|
|
defer tests.PrintCurrentTest(t)()
|
|
issueList, err := issues.LoadIssuesFromColumn(db.DefaultContext, column, nil, nil, optional.None[bool]())
|
|
require.NoError(t, err)
|
|
assert.Len(t, issueList, 1)
|
|
assert.EqualValues(t, 1, issueList[0].ID)
|
|
|
|
issuesNum, err := issues.NumIssuesInProject(db.DefaultContext, userProject, nil, nil, optional.None[bool]())
|
|
require.NoError(t, err)
|
|
assert.EqualValues(t, 1, issuesNum)
|
|
|
|
issuesNum, err = issues.NumIssuesInProject(db.DefaultContext, userProject, nil, nil, optional.Some(true))
|
|
require.NoError(t, err)
|
|
assert.EqualValues(t, 0, issuesNum)
|
|
|
|
issuesNum, err = issues.NumIssuesInProject(db.DefaultContext, userProject, nil, nil, optional.Some(false))
|
|
require.NoError(t, err)
|
|
assert.EqualValues(t, 1, issuesNum)
|
|
})
|
|
})
|
|
}
|