mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2024-10-30 17:34:13 +01:00
f8b471ace1
Fixes #28660 Fixes an admin api bug related to `user.LoginSource` Fixed `/user/emails` response not identical to GitHub api This PR unifies the user update methods. The goal is to keep the logic only at one place (having audit logs in mind). For example, do the password checks only in one method not everywhere a password is updated. After that PR is merged, the user creation should be next.
125 lines
3.9 KiB
Go
125 lines
3.9 KiB
Go
// Copyright 2021 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package ldap
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"strings"
|
|
|
|
asymkey_model "code.gitea.io/gitea/models/asymkey"
|
|
"code.gitea.io/gitea/models/auth"
|
|
user_model "code.gitea.io/gitea/models/user"
|
|
auth_module "code.gitea.io/gitea/modules/auth"
|
|
"code.gitea.io/gitea/modules/optional"
|
|
"code.gitea.io/gitea/modules/util"
|
|
source_service "code.gitea.io/gitea/services/auth/source"
|
|
user_service "code.gitea.io/gitea/services/user"
|
|
)
|
|
|
|
// Authenticate queries if login/password is valid against the LDAP directory pool,
|
|
// and create a local user if success when enabled.
|
|
func (source *Source) Authenticate(ctx context.Context, user *user_model.User, userName, password string) (*user_model.User, error) {
|
|
loginName := userName
|
|
if user != nil {
|
|
loginName = user.LoginName
|
|
}
|
|
sr := source.SearchEntry(loginName, password, source.authSource.Type == auth.DLDAP)
|
|
if sr == nil {
|
|
// User not in LDAP, do nothing
|
|
return nil, user_model.ErrUserNotExist{Name: loginName}
|
|
}
|
|
// Fallback.
|
|
if len(sr.Username) == 0 {
|
|
sr.Username = userName
|
|
}
|
|
if len(sr.Mail) == 0 {
|
|
sr.Mail = fmt.Sprintf("%s@localhost.local", sr.Username)
|
|
}
|
|
isAttributeSSHPublicKeySet := len(strings.TrimSpace(source.AttributeSSHPublicKey)) > 0
|
|
|
|
// Update User admin flag if exist
|
|
if isExist, err := user_model.IsUserExist(ctx, 0, sr.Username); err != nil {
|
|
return nil, err
|
|
} else if isExist {
|
|
if user == nil {
|
|
user, err = user_model.GetUserByName(ctx, sr.Username)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
}
|
|
if user != nil && !user.ProhibitLogin {
|
|
opts := &user_service.UpdateOptions{}
|
|
if len(source.AdminFilter) > 0 && user.IsAdmin != sr.IsAdmin {
|
|
// Change existing admin flag only if AdminFilter option is set
|
|
opts.IsAdmin = optional.Some(sr.IsAdmin)
|
|
}
|
|
if !sr.IsAdmin && len(source.RestrictedFilter) > 0 && user.IsRestricted != sr.IsRestricted {
|
|
// Change existing restricted flag only if RestrictedFilter option is set
|
|
opts.IsRestricted = optional.Some(sr.IsRestricted)
|
|
}
|
|
if opts.IsAdmin.Has() || opts.IsRestricted.Has() {
|
|
if err := user_service.UpdateUser(ctx, user, opts); err != nil {
|
|
return nil, err
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
if user != nil {
|
|
if isAttributeSSHPublicKeySet && asymkey_model.SynchronizePublicKeys(ctx, user, source.authSource, sr.SSHPublicKey) {
|
|
if err := asymkey_model.RewriteAllPublicKeys(ctx); err != nil {
|
|
return user, err
|
|
}
|
|
}
|
|
} else {
|
|
user = &user_model.User{
|
|
LowerName: strings.ToLower(sr.Username),
|
|
Name: sr.Username,
|
|
FullName: composeFullName(sr.Name, sr.Surname, sr.Username),
|
|
Email: sr.Mail,
|
|
LoginType: source.authSource.Type,
|
|
LoginSource: source.authSource.ID,
|
|
LoginName: userName,
|
|
IsAdmin: sr.IsAdmin,
|
|
}
|
|
overwriteDefault := &user_model.CreateUserOverwriteOptions{
|
|
IsRestricted: util.OptionalBoolOf(sr.IsRestricted),
|
|
IsActive: util.OptionalBoolTrue,
|
|
}
|
|
|
|
err := user_model.CreateUser(ctx, user, overwriteDefault)
|
|
if err != nil {
|
|
return user, err
|
|
}
|
|
|
|
if isAttributeSSHPublicKeySet && asymkey_model.AddPublicKeysBySource(ctx, user, source.authSource, sr.SSHPublicKey) {
|
|
if err := asymkey_model.RewriteAllPublicKeys(ctx); err != nil {
|
|
return user, err
|
|
}
|
|
}
|
|
if len(source.AttributeAvatar) > 0 {
|
|
if err := user_service.UploadAvatar(ctx, user, sr.Avatar); err != nil {
|
|
return user, err
|
|
}
|
|
}
|
|
}
|
|
|
|
if source.GroupsEnabled && (source.GroupTeamMap != "" || source.GroupTeamMapRemoval) {
|
|
groupTeamMapping, err := auth_module.UnmarshalGroupTeamMapping(source.GroupTeamMap)
|
|
if err != nil {
|
|
return user, err
|
|
}
|
|
if err := source_service.SyncGroupsToTeams(ctx, user, sr.Groups, groupTeamMapping, source.GroupTeamMapRemoval); err != nil {
|
|
return user, err
|
|
}
|
|
}
|
|
|
|
return user, nil
|
|
}
|
|
|
|
// IsSkipLocalTwoFA returns if this source should skip local 2fa for password authentication
|
|
func (source *Source) IsSkipLocalTwoFA() bool {
|
|
return source.SkipLocalTwoFA
|
|
}
|