NYANDEV/forgejo
NYANDEV/forgejo
4
0
Fork 1
mirror of https://codeberg.org/forgejo/forgejo.git synced 2024-11-14 18:24:14 +01:00
Code Issues 2 Projects 1 Releases Packages Wiki Activity
forgejo/routers/web/repo
History
Giteabot 2ab54a9c06
Fix issue dependencies (#27736) (#28776) 
Backport #27736 by @lng2020

Fix #27722
Fix #27357
Fix #25837
Fix #28732
1. Fix the typo `BlockingByDependenciesNotPermitted`, which causes the
`not permitted message` not to show. The correct one is `Blocking` or
`BlockedBy`
2. Rewrite the perm check. The perm check uses a very tricky way to
avoid duplicate checks for a slice of issues, which is confusing. In
fact, it's also the reason causing the bug. It uses `lastRepoID` and
`lastPerm` to avoid duplicate checks, but forgets to assign the
`lastPerm` at the end of the code block. So I rewrote this to avoid this
trick.
![I U1AT{GNFY3
1HZ`6L{(2L](https://github.com/go-gitea/gitea/assets/70063547/79acd02a-a567-4316-ae0d-11c6461becf1)
3. It also reuses the `blocks` slice, which is even more confusing. So I
rewrote this too.

![UARFPXRGGZQFB7J$2`R}5_R](https://github.com/go-gitea/gitea/assets/70063547/f21cff0f-d9ac-4ce4-ae4d-adffc98ecd99)

Co-authored-by: Nanguan Lin <70063547+lng2020@users.noreply.github.com>
(cherry picked from commit 571822b6ec)
2024-01-16 14:39:23 +00:00
..
actions Only check online runner when detecting matching runners in workflows (#28286) (#28512) 2023-12-22 12:10:03 +01:00
setting Fix comment permissions (#28213) (#28216) 2023-11-26 13:56:50 +01:00
activity.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
attachment.go More refactoring of db.DefaultContext (#27083) 2023-09-15 06:13:19 +00:00
blame.go Use information from previous blame parts (#28572) (#28577) 2023-12-22 12:10:03 +01:00
branch.go Also sync DB branches on push if necessary (#28361) (#28403) 2023-12-12 15:21:33 +01:00
cherry_pick.go Sync branches into databases (#22743) 2023-06-29 10:03:20 +00:00
commit.go [GITEA] Detect file rename and show in history 2023-11-13 14:06:30 +01:00
compare.go Replace ajax with fetch, improve image diff (#27267) (#27583) 2023-10-11 16:12:31 +02:00
download.go Less naked returns (#25713) 2023-07-07 05:31:56 +00:00
editor.go Revert "Fix EOL handling in web editor" (#28101) (#28172) 2023-11-22 17:14:40 +01:00
editor_test.go Move web/api context related testing function into a separate package (#26859) 2023-09-01 11:26:07 +00:00
find.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
githttp.go Fix http protocol auth (#27875) (#27876) 2023-11-02 16:34:55 +01:00
githttp_test.go Fix http protocol auth (#27875) (#27876) 2023-11-02 16:34:55 +01:00
helper.go Improve tree not found page (#26570) (#27346) 2023-09-29 18:35:11 +08:00
helper_test.go Make web context initialize correctly for different cases (#26726) 2023-08-25 19:07:42 +08:00
issue.go Fix issue dependencies (#27736) (#28776) 2024-01-16 14:39:23 +00:00
issue_content_history.go [GITEA] Fix panic in canSoftDeleteContentHistory 2024-01-13 22:05:35 +01:00
issue_dependency.go Add context parameter to some database functions (#26055) 2023-07-22 22:14:27 +08:00
issue_label.go Next round of db.DefaultContext refactor (#27089) 2023-09-16 14:39:12 +00:00
issue_label_test.go Move web/api context related testing function into a separate package (#26859) 2023-09-01 11:26:07 +00:00
issue_lock.go Use fetch form action for lock/unlock/pin/unpin on sidebar (#25380) 2023-06-29 04:16:04 +00:00
issue_pin.go Fix missing check (#28406) (#28411) 2023-12-12 15:21:32 +01:00
issue_stopwatch.go Next round of db.DefaultContext refactor (#27089) 2023-09-16 14:39:12 +00:00
issue_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
issue_timetrack.go Add context parameter to some database functions (#26055) 2023-07-22 22:14:27 +08:00
issue_watch.go Next round of db.DefaultContext refactor (#27089) 2023-09-16 14:39:12 +00:00
main_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
middlewares.go Fix viewing wiki commit on empty repo (#28040) (#28044) 2023-11-22 17:11:57 +01:00
migrate.go Next round of db.DefaultContext refactor (#27089) 2023-09-16 14:39:12 +00:00
milestone.go Fix link-action redirect network error (#27734) (#27749) 2023-10-23 13:52:30 +00:00
packages.go Fix the display of org level badges (#26504) 2023-09-06 14:38:14 +08:00
patch.go Sync branches into databases (#22743) 2023-06-29 10:03:20 +00:00
projects.go Fix comment permissions (#28213) (#28216) 2023-11-26 13:56:50 +01:00
projects_test.go Move web/api context related testing function into a separate package (#26859) 2023-09-01 11:26:07 +00:00
pull.go Fix status_check_contexts matching bug (#28582) (#28589) 2024-01-16 14:07:46 +00:00
pull_review.go More db.DefaultContext refactor (#27265) (#27347) 2023-09-29 13:35:01 +00:00
release.go Fix comment permissions (#28213) (#28216) 2023-11-26 13:56:50 +01:00
release_test.go Move web/api context related testing function into a separate package (#26859) 2023-09-01 11:26:07 +00:00
render.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
repo.go [GITEA] Handle non-existant commit in Archive request 2024-01-04 23:56:33 +01:00
search.go Refactor indexer (#25174) 2023-06-23 12:37:56 +00:00
topic.go Next round of db.DefaultContext refactor (#27089) 2023-09-16 14:39:12 +00:00
treelist.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
view.go Add option to disable ambiguous unicode characters detection (#28454) (#28499) 2023-12-22 12:07:01 +01:00
view_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
wiki.go Move notification interface to services layer (#26915) 2023-09-05 18:37:47 +00:00
wiki_test.go Move web/api context related testing function into a separate package (#26859) 2023-09-01 11:26:07 +00:00