forgejo/services
zeripath 6bab678bed
Fix diff skipping lines (#13154)
* Fix diff skipping lines

ParsePatch previously just skipped all lines that start with "+++ " or "--- "
and makes no attempt to see these lines in context.

This PR rewrites ParsePatch to pay attention to context and position
within a patch, ensuring that --- and +++ are only skipped if
appropriate.

This PR also fixes several issues with incomplete files.

Fix https://codeberg.org/Codeberg/Community/issues/308
Fix #13153

Signed-off-by: Andrew Thornton <art27@cantab.net>

* Add testcase

Signed-off-by: Andrew Thornton <art27@cantab.net>

* fix comment

* simplify error handling

Signed-off-by: Andrew Thornton <art27@cantab.net>

* never return io.EOF

Signed-off-by: Andrew Thornton <art27@cantab.net>

Co-authored-by: Lauris BH <lauris@nix.lv>
2020-10-16 13:13:18 -04:00
..
comments Refactor pull request review (#8954) 2019-11-14 10:57:36 +08:00
externalaccount Allow externalID to be UUID (#8551) 2019-10-17 10:06:28 +08:00
gitdiff Fix diff skipping lines (#13154) 2020-10-16 13:13:18 -04:00
issue Add team support for review request (#12039) 2020-10-12 20:55:13 +01:00
mailer Fix "only mail on mention" bug (#12775) 2020-09-09 15:08:55 -04:00
mirror Mirror: Update DB on Address-Update too (#12964) 2020-09-28 15:00:52 -04:00
pull [Enhancement] Allow admin to merge pr with protected file changes (#12078) 2020-10-13 14:50:57 -04:00
release Add a storage layer for attachments (#11387) 2020-08-18 12:23:45 +08:00
repository Move update-server-info to hooks (#12826) 2020-10-14 00:24:06 +08:00
wiki Update golangci-lint to version 1.31.0 (#13102) 2020-10-11 21:27:20 +01:00