forgejo/models/forgejo_migrations
Gusted 138942c09e
[CHORE] Move test related function to own package
- Go's deadcode eliminator is quite simple, if you put a public function
in a package `aa/bb` that is used only by tests, it would still be built
if package `aa/bb` was imported. This means that if such functions use
libraries relevant only to tests that those libraries would still be
be built and increase the binary size of a Go binary.
- This is also the case with Forgejo, `models/migrations/base/tests.go`
contained functions exclusively used by tests which (skipping some steps
here) imports https://github.com/ClickHouse/clickhouse-go, which is
2MiB. The `code.gitea.io/gitea/models/migrations/base` package is
imported by `cmd/doctor` and thus the code of the clickhouse library is
also built and included in the Forgejo binary, although entirely unused
and not reachable.
- This patch moves the test-related functions to their own package, so
Go's deadcode eliminator knows not to build the test-related functions
and thus reduces the size of the Forgejo binary.
- It is not possible to move this to a `_test.go` file because Go does
not allow importing functions from such files, so any test helper
function must be in a non-test package and file.
- Reduction of size (built with `TAGS="sqlite sqlite_unlock_notify" make
build`):
  - Before: 95912040 bytes (92M)
  - After: 92306888 bytes (89M)
2024-07-14 17:00:49 +02:00
..
v1_20 [SECURITY] Rework long-term authentication 2024-02-05 15:06:15 +01:00
v1_22 [CHORE] Move test related function to own package 2024-07-14 17:00:49 +02:00
main_test.go [CHORE] Move test related function to own package 2024-07-14 17:00:49 +02:00
migrate.go fix review 2024-05-29 18:31:06 +02:00
migrate_test.go [CHORE] Move test related function to own package 2024-07-14 17:00:49 +02:00
v13.go [FEAT]Add Option to hide Release Archive links (#3139) 2024-04-24 15:15:55 +00:00
v14.go Drop Gitea-specific columns from two tables 2024-04-26 10:34:06 +02:00
v15.go enhance test & fix reviews 2024-05-14 08:24:31 +02:00
v16.go add migration & enhance int-test 2024-05-16 18:25:16 +02:00
v17.go add migration & enhance int-test 2024-05-16 18:25:16 +02:00
v18.go fix review 2024-05-29 18:31:06 +02:00