Earl Warren
cc6321baf7
chore(release-notes): notes for the week 2024-47 weekly cherry pick
2024-11-18 19:20:54 +01:00
Earl Warren
3c3c9b22a9
Merge pull request 'chore(ci): make release-notes-assistant job copy/pastable (part two)' ( #6020 ) from earl-warren/forgejo:wip-ci-labels into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/6020
Reviewed-by: Michael Kriese <michael.kriese@gmx.de>
2024-11-18 18:10:13 +00:00
Earl Warren
73cb6c9204
chore(ci): make release-notes-assistant job copy/pastable (part two)
...
The event is pull_request_target
Refs: forgejo/forgejo#5999
2024-11-18 18:11:07 +01:00
Earl Warren
25354c03a5
Merge pull request 'chore(ci): make release-notes-assistant job copy/pastable' ( #6019 ) from earl-warren/forgejo:wip-ci-labels into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/6019
Reviewed-by: Michael Kriese <michael.kriese@gmx.de>
2024-11-18 17:02:59 +00:00
Earl Warren
18cecf124f
chore(ci): make release-notes-assistant job copy/pastable
...
Refs: forgejo/forgejo#5999
2024-11-18 17:23:33 +01:00
Earl Warren
2f1b1d8b80
Merge pull request 'feat: use oci mirror for tonistiigi/xx
image' ( #5965 ) from viceice/feat/oci-mirror into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/5965
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-11-18 14:54:05 +00:00
0ko
c3653e0eaa
ui: don't display email in profile settings when hidden
2024-11-18 17:06:38 +05:00
Earl Warren
4a3f8f3004
Merge pull request 'fix(test): TestGitAttributeCheckerError must allow broken pipe' ( #6013 ) from earl-warren/forgejo:wip-ci-cancel into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/6013
Reviewed-by: oliverpool <oliverpool@noreply.codeberg.org>
2024-11-18 11:28:52 +00:00
Otto
6cfaebf043
Merge pull request 'chore(ci): make backporting job copy/pastable' ( #6002 ) from earl-warren/forgejo:wip-ci-labels-backports into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/6002
Reviewed-by: Otto <otto@codeberg.org>
2024-11-18 10:44:38 +00:00
Earl Warren
e0b37253c8
Merge pull request 'Lock file maintenance (forgejo)' ( #6010 ) from renovate/forgejo-lock-file-maintenance into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/6010
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-11-18 07:24:40 +00:00
Earl Warren
b9697f5227
fix(test): TestGitAttributeCheckerError must allow broken pipe
...
Early cancelation can lead to two kinds of error. Either canceled or
broken pipe, depending on when the goroutine stops.
Fixes : forgejo/forgejo#6012
2024-11-18 08:20:10 +01:00
Renovate Bot
6553148de9
Update renovate to v39.19.1 (forgejo) ( #6008 )
...
Co-authored-by: Renovate Bot <forgejo-renovate-action@forgejo.org>
Co-committed-by: Renovate Bot <forgejo-renovate-action@forgejo.org>
2024-11-18 05:52:58 +00:00
Renovate Bot
387ed7e072
Lock file maintenance
2024-11-18 00:05:26 +00:00
Otto
289c22cc4a
Merge pull request 'fix: vertical center the date on GPG keys' ( #6006 ) from gusted/forgejo-ui-gpg into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/6006
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
Reviewed-by: Otto <otto@codeberg.org>
2024-11-17 23:17:19 +00:00
Renovate Bot
4163402f5e
Update dependency vue to v3.5.13 (forgejo) ( #5981 )
...
Co-authored-by: Renovate Bot <forgejo-renovate-action@forgejo.org>
Co-committed-by: Renovate Bot <forgejo-renovate-action@forgejo.org>
2024-11-17 21:23:23 +00:00
Lunny Xiao
f6a46055aa
Reimplement GetUserOrgsList to make it simple and clear ( #32486 )
...
Reimplement GetUserOrgsList and also move some functions and test to
org_list file.
---------
Co-authored-by: Zettat123 <zettat123@gmail.com>
(cherry picked from commit b4abb6deff14b741c7666d7579e0eea68443306c)
Conflicts:
models/organization/org_test.go
services/oauth2_provider/access_token.go
trivial conflicts due to codeblocks moving to different files
2024-11-17 21:57:34 +01:00
6543
7751bb64cb
Calculate PublicOnly
for org membership only once ( #32234 )
...
Refactoring of #32211
this move the PublicOnly() filter calcuation next to the DB querys and
let it be decided by the Doer
---
*Sponsored by Kithara Software GmbH*
(cherry picked from commit 43c252dfeaf9ab03c4db3e7ac5169bc0d69901ac)
Conflicts:
models/organization/org_test.go
models/organization/org_user_test.go
routers/web/org/home.go
rather simple conflict resolution but not trivial
tests/integration/user_count_test.go had to be adapted (simple)
because it does not exist in Gitea and uses the modified model
2024-11-17 21:57:34 +01:00
Gusted
662e9c53d9
fix: vertical center the date on GPG keys
...
- Ensure the 'added on' and the date are centered vertically the same.
- Regression #5796
2024-11-17 21:53:37 +01:00
wxiaoguang
45435a8789
Fix and refactor markdown rendering ( #32522 )
...
(cherry picked from commit 5eebe1dc5fb29a162c51d050396fce7b14e47f4e)
Conflicts:
models/repo/repo.go
models/repo/repo_test.go
modules/markup/html.go
modules/markup/html_commit.go
modules/markup/html_email.go
modules/markup/html_emoji.go
modules/markup/html_internal_test.go
modules/markup/html_issue.go
modules/markup/html_link.go
modules/markup/html_node.go
modules/markup/html_test.go
modules/markup/markdown/goldmark.go
modules/markup/markdown/markdown_test.go
modules/markup/markdown/transform_image.go
modules/markup/orgmode/orgmode.go
modules/markup/orgmode/orgmode_test.go
modules/markup/render.go
modules/markup/render_links.go
modules/templates/util_render.go
modules/templates/util_render_test.go
routers/common/markup.go
routers/web/feed/convert.go
routers/web/repo/wiki.go
but a few lines survived and are useful
2024-11-17 20:34:28 +01:00
Gusted
e31090cf4b
Merge pull request 'fix: check read permissions for code owner review requests' ( #5996 ) from gusted/forgejo-codeowners into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/5996
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-11-17 19:13:46 +00:00
Gusted
2cc3278791
Merge pull request 'fix: use better code to group UID and stopwatches' ( #5989 ) from gusted/improve-uid-stopwatches into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/5989
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-11-17 19:13:30 +00:00
Gusted
693f7731f9
fix: check read permissions for code owner review requests
...
- Only send a review request based on the code owner file if the code
owner user has read permissions to the pull requests of that repository.
- This avoids leaking title of PRs from private repository when a
CODEOWNER file is present which contains users that do not have access
to the private repository.
- Found by @oliverpool.
- Integration test added.
2024-11-17 20:12:59 +01:00
Earl Warren
02f4d3bd2d
chore(release-notes-assistant): security fix / features come first
2024-11-17 20:03:11 +01:00
Earl Warren
b6869d643e
chore(ci): make backporting job copy/pastable
...
Refs: forgejo/forgejo#5999
2024-11-17 19:17:11 +01:00
Earl Warren
abec2442b7
Merge pull request 'chore(ci): make merge-conditions job copy/pastable' ( #6001 ) from earl-warren/forgejo:wip-ci-labels into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/6001
Reviewed-by: Michael Kriese <michael.kriese@gmx.de>
2024-11-17 18:13:16 +00:00
Earl Warren
64a89c8d33
chore(ci): make merge-conditions job copy/pastable
...
Refs: forgejo/forgejo#5999
2024-11-17 17:57:40 +01:00
Gusted
76f172b080
Merge pull request 'fix: remember fuzzy for open/close state' ( #5995 ) from gusted/forgejo-remember-fuzzy into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/5995
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
Reviewed-by: Shiny Nematoda <snematoda@noreply.codeberg.org>
2024-11-17 15:27:48 +00:00
Earl Warren
a5363a539b
Merge pull request 'chore(ci): make end-to-end job copy/pastable' ( #6000 ) from earl-warren/forgejo:wip-ci-labels into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/6000
Reviewed-by: Michael Kriese <michael.kriese@gmx.de>
2024-11-17 13:33:43 +00:00
Earl Warren
b5161325ef
chore(ci): make end-to-end job copy/pastable
...
Refs: forgejo/forgejo#5999
2024-11-17 13:33:21 +01:00
Lunny Xiao
a8f2002a9b
Remove transaction for archive download ( #32186 )
...
Since there is a status column in the database, the transaction is
unnecessary when downloading an archive. The transaction is blocking
database operations, especially with SQLite.
Replace #27563
(cherry picked from commit e1b269e956e955dd1dfb012f40270d73f8329092)
2024-11-17 12:18:57 +01:00
Lunny Xiao
96ee0f5647
Fix oauth2 error handle not return immediately ( #32514 )
...
(cherry picked from commit 4121f952d18a4c3a3c08ae645af3458ef08b439d)
2024-11-17 12:18:56 +01:00
Lunny Xiao
c2e8790df3
Trim title before insert/update to database to match the size requirements of database ( #32498 )
...
Fix #32489
(cherry picked from commit 98d9a71ffe510da0e10d042d8f87a348022aca87)
2024-11-17 12:18:56 +01:00
wxiaoguang
03ab73d92e
Fix nil panic if repo doesn't exist ( #32501 )
...
fix #32496
(cherry picked from commit 985e2a8af3d6468bac3ab178148c38bdbd8414f5)
2024-11-17 12:18:56 +01:00
Lunny Xiao
56971f9ed9
Disable Oauth check if oauth disabled ( #32368 )
...
Fix #32367
---------
Co-authored-by: Giteabot <teabot@gitea.io>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
(cherry picked from commit 840ad7eefe2b49ab453b9a89b153a264a8c9f8a2)
Conflicts:
services/auth/oauth2.go
trivial context conflict
2024-11-17 12:18:56 +01:00
ChristopherHX
7f51210672
Harden runner updateTask and updateLog api ( #32462 )
...
Per proposal https://github.com/go-gitea/gitea/issues/32461
(cherry picked from commit f888e45432ccb86b18e6709fbd25223e07f2c422)
2024-11-17 08:45:37 +01:00
Zettat123
dd3c4d7096
Add a doctor check to disable the "Actions" unit for mirrors ( #32424 )
...
Resolve #32232
Users can disable the "Actions" unit for all mirror repos by running
```
gitea doctor check --run disable-mirror-actions-unit --fix
```
(cherry picked from commit a910abbb451ea89b8279b43bd818a140fe0f3b51)
2024-11-17 08:38:34 +01:00
Gusted
9701e5e0ff
fix: remember fuzzy for open/close state
...
- Remember if fuzzy was set or not for the open/close/all states.
- Use `fuzzy=false` for test, as `fuzzy=true` is the default (this is
the opposite of all the other values).
- Remove `ctx.Link` prefix for open/close states, this makes them
suspectible to the existing tests (the other filter links are also in
the format of simply having `?xx=xx&yy=yy`).
- Fix typo in test name.
2024-11-17 02:06:51 +01:00
Gusted
da40383cf4
Revert defaulting to EdDSA
...
- Apparently JWT actually checks when doing a JWT operation if the key type is valid and not on startup, this caused errors unfortunately.
2024-11-17 00:42:31 +00:00
Gusted
8e94947ed9
Merge pull request 'fix: api repo compare with commit hashes' ( #5991 ) from angelnu/forgejo:angelnu/IsCommitExist into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/5991
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
2024-11-16 23:35:34 +00:00
Gusted
c01a03e93d
Merge pull request 'feat: default to generating EdDSA for OAuth JWT signing key' ( #5987 ) from gusted/forgejo-default-eddsa-oauth-jwt into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/5987
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-11-16 23:34:58 +00:00
Angel Nunez Mencias
ca0cd42d7a
simplify test based on feedback
2024-11-16 22:31:14 +01:00
Angel Nunez Mencias
01c9c19536
fmt
2024-11-16 18:12:40 +01:00
angelnu
1b9d1240eb
add test
2024-11-16 18:12:40 +01:00
angelnu
d2dc4fae3a
review changes
2024-11-16 18:12:40 +01:00
angelnu
e434ecdaca
check IsCommitExist
2024-11-16 18:12:40 +01:00
Earl Warren
569a67327c
Merge pull request 'bug: correctly generate oauth2 jwt signing key' ( #5986 ) from gusted/improve-oauth2-jwt into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/5986
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-11-16 17:04:31 +00:00
Gusted
146824badc
Merge pull request 'feat: improve GetLatestCommitStatusForPairs
' ( #5983 ) from gusted/improve-commit-pairs into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/5983
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
Reviewed-by: Otto <otto@codeberg.org>
2024-11-16 15:54:40 +00:00
Earl Warren
eaa66f85f6
Merge pull request '[gitea] week 2024-46 cherry pick (gitea/main -> forgejo)' ( #5988 ) from earl-warren/wcp/2024-46 into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/5988
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
2024-11-16 15:49:01 +00:00
Gusted
e4eb82b738
fix: use better code to group UID and stopwatches
...
- Instead of having code that relied on the result being sorted (which
wasn't specified in the query and therefore not safe to assume so). Use
a map where it doesn't care if the result that we get from the database
is sorted or not.
- Added unit test.
2024-11-16 15:59:02 +01:00
Earl Warren
969a6ab24a
chore(release-notes): notes for the week 2024-46 weekly cherry pick
2024-11-16 15:25:37 +01:00