6543
7751bb64cb
Calculate PublicOnly
for org membership only once ( #32234 )
...
Refactoring of #32211
this move the PublicOnly() filter calcuation next to the DB querys and
let it be decided by the Doer
---
*Sponsored by Kithara Software GmbH*
(cherry picked from commit 43c252dfeaf9ab03c4db3e7ac5169bc0d69901ac)
Conflicts:
models/organization/org_test.go
models/organization/org_user_test.go
routers/web/org/home.go
rather simple conflict resolution but not trivial
tests/integration/user_count_test.go had to be adapted (simple)
because it does not exist in Gitea and uses the modified model
2024-11-17 21:57:34 +01:00
Gusted
662e9c53d9
fix: vertical center the date on GPG keys
...
- Ensure the 'added on' and the date are centered vertically the same.
- Regression #5796
2024-11-17 21:53:37 +01:00
wxiaoguang
45435a8789
Fix and refactor markdown rendering ( #32522 )
...
(cherry picked from commit 5eebe1dc5fb29a162c51d050396fce7b14e47f4e)
Conflicts:
models/repo/repo.go
models/repo/repo_test.go
modules/markup/html.go
modules/markup/html_commit.go
modules/markup/html_email.go
modules/markup/html_emoji.go
modules/markup/html_internal_test.go
modules/markup/html_issue.go
modules/markup/html_link.go
modules/markup/html_node.go
modules/markup/html_test.go
modules/markup/markdown/goldmark.go
modules/markup/markdown/markdown_test.go
modules/markup/markdown/transform_image.go
modules/markup/orgmode/orgmode.go
modules/markup/orgmode/orgmode_test.go
modules/markup/render.go
modules/markup/render_links.go
modules/templates/util_render.go
modules/templates/util_render_test.go
routers/common/markup.go
routers/web/feed/convert.go
routers/web/repo/wiki.go
but a few lines survived and are useful
2024-11-17 20:34:28 +01:00
Gusted
e31090cf4b
Merge pull request 'fix: check read permissions for code owner review requests' ( #5996 ) from gusted/forgejo-codeowners into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/5996
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-11-17 19:13:46 +00:00
Gusted
2cc3278791
Merge pull request 'fix: use better code to group UID and stopwatches' ( #5989 ) from gusted/improve-uid-stopwatches into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/5989
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-11-17 19:13:30 +00:00
Gusted
693f7731f9
fix: check read permissions for code owner review requests
...
- Only send a review request based on the code owner file if the code
owner user has read permissions to the pull requests of that repository.
- This avoids leaking title of PRs from private repository when a
CODEOWNER file is present which contains users that do not have access
to the private repository.
- Found by @oliverpool.
- Integration test added.
2024-11-17 20:12:59 +01:00
Earl Warren
02f4d3bd2d
chore(release-notes-assistant): security fix / features come first
2024-11-17 20:03:11 +01:00
Earl Warren
b6869d643e
chore(ci): make backporting job copy/pastable
...
Refs: forgejo/forgejo#5999
2024-11-17 19:17:11 +01:00
Earl Warren
abec2442b7
Merge pull request 'chore(ci): make merge-conditions job copy/pastable' ( #6001 ) from earl-warren/forgejo:wip-ci-labels into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/6001
Reviewed-by: Michael Kriese <michael.kriese@gmx.de>
2024-11-17 18:13:16 +00:00
Earl Warren
64a89c8d33
chore(ci): make merge-conditions job copy/pastable
...
Refs: forgejo/forgejo#5999
2024-11-17 17:57:40 +01:00
Gusted
76f172b080
Merge pull request 'fix: remember fuzzy for open/close state' ( #5995 ) from gusted/forgejo-remember-fuzzy into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/5995
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
Reviewed-by: Shiny Nematoda <snematoda@noreply.codeberg.org>
2024-11-17 15:27:48 +00:00
Earl Warren
a5363a539b
Merge pull request 'chore(ci): make end-to-end job copy/pastable' ( #6000 ) from earl-warren/forgejo:wip-ci-labels into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/6000
Reviewed-by: Michael Kriese <michael.kriese@gmx.de>
2024-11-17 13:33:43 +00:00
Earl Warren
b5161325ef
chore(ci): make end-to-end job copy/pastable
...
Refs: forgejo/forgejo#5999
2024-11-17 13:33:21 +01:00
Lunny Xiao
a8f2002a9b
Remove transaction for archive download ( #32186 )
...
Since there is a status column in the database, the transaction is
unnecessary when downloading an archive. The transaction is blocking
database operations, especially with SQLite.
Replace #27563
(cherry picked from commit e1b269e956e955dd1dfb012f40270d73f8329092)
2024-11-17 12:18:57 +01:00
Lunny Xiao
96ee0f5647
Fix oauth2 error handle not return immediately ( #32514 )
...
(cherry picked from commit 4121f952d18a4c3a3c08ae645af3458ef08b439d)
2024-11-17 12:18:56 +01:00
Lunny Xiao
c2e8790df3
Trim title before insert/update to database to match the size requirements of database ( #32498 )
...
Fix #32489
(cherry picked from commit 98d9a71ffe510da0e10d042d8f87a348022aca87)
2024-11-17 12:18:56 +01:00
wxiaoguang
03ab73d92e
Fix nil panic if repo doesn't exist ( #32501 )
...
fix #32496
(cherry picked from commit 985e2a8af3d6468bac3ab178148c38bdbd8414f5)
2024-11-17 12:18:56 +01:00
Lunny Xiao
56971f9ed9
Disable Oauth check if oauth disabled ( #32368 )
...
Fix #32367
---------
Co-authored-by: Giteabot <teabot@gitea.io>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
(cherry picked from commit 840ad7eefe2b49ab453b9a89b153a264a8c9f8a2)
Conflicts:
services/auth/oauth2.go
trivial context conflict
2024-11-17 12:18:56 +01:00
ChristopherHX
7f51210672
Harden runner updateTask and updateLog api ( #32462 )
...
Per proposal https://github.com/go-gitea/gitea/issues/32461
(cherry picked from commit f888e45432ccb86b18e6709fbd25223e07f2c422)
2024-11-17 08:45:37 +01:00
Zettat123
dd3c4d7096
Add a doctor check to disable the "Actions" unit for mirrors ( #32424 )
...
Resolve #32232
Users can disable the "Actions" unit for all mirror repos by running
```
gitea doctor check --run disable-mirror-actions-unit --fix
```
(cherry picked from commit a910abbb451ea89b8279b43bd818a140fe0f3b51)
2024-11-17 08:38:34 +01:00
Gusted
9701e5e0ff
fix: remember fuzzy for open/close state
...
- Remember if fuzzy was set or not for the open/close/all states.
- Use `fuzzy=false` for test, as `fuzzy=true` is the default (this is
the opposite of all the other values).
- Remove `ctx.Link` prefix for open/close states, this makes them
suspectible to the existing tests (the other filter links are also in
the format of simply having `?xx=xx&yy=yy`).
- Fix typo in test name.
2024-11-17 02:06:51 +01:00
Gusted
da40383cf4
Revert defaulting to EdDSA
...
- Apparently JWT actually checks when doing a JWT operation if the key type is valid and not on startup, this caused errors unfortunately.
2024-11-17 00:42:31 +00:00
Gusted
8e94947ed9
Merge pull request 'fix: api repo compare with commit hashes' ( #5991 ) from angelnu/forgejo:angelnu/IsCommitExist into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/5991
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
2024-11-16 23:35:34 +00:00
Gusted
c01a03e93d
Merge pull request 'feat: default to generating EdDSA for OAuth JWT signing key' ( #5987 ) from gusted/forgejo-default-eddsa-oauth-jwt into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/5987
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-11-16 23:34:58 +00:00
Angel Nunez Mencias
ca0cd42d7a
simplify test based on feedback
2024-11-16 22:31:14 +01:00
Angel Nunez Mencias
01c9c19536
fmt
2024-11-16 18:12:40 +01:00
angelnu
1b9d1240eb
add test
2024-11-16 18:12:40 +01:00
angelnu
d2dc4fae3a
review changes
2024-11-16 18:12:40 +01:00
angelnu
e434ecdaca
check IsCommitExist
2024-11-16 18:12:40 +01:00
Earl Warren
569a67327c
Merge pull request 'bug: correctly generate oauth2 jwt signing key' ( #5986 ) from gusted/improve-oauth2-jwt into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/5986
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-11-16 17:04:31 +00:00
Gusted
146824badc
Merge pull request 'feat: improve GetLatestCommitStatusForPairs
' ( #5983 ) from gusted/improve-commit-pairs into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/5983
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
Reviewed-by: Otto <otto@codeberg.org>
2024-11-16 15:54:40 +00:00
Earl Warren
eaa66f85f6
Merge pull request '[gitea] week 2024-46 cherry pick (gitea/main -> forgejo)' ( #5988 ) from earl-warren/wcp/2024-46 into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/5988
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
2024-11-16 15:49:01 +00:00
Gusted
e4eb82b738
fix: use better code to group UID and stopwatches
...
- Instead of having code that relied on the result being sorted (which
wasn't specified in the query and therefore not safe to assume so). Use
a map where it doesn't care if the result that we get from the database
is sorted or not.
- Added unit test.
2024-11-16 15:59:02 +01:00
Earl Warren
969a6ab24a
chore(release-notes): notes for the week 2024-46 weekly cherry pick
2024-11-16 15:25:37 +01:00
Gusted
7d59060dc6
bug: correctly generate oauth2 jwt signing key
...
- When RS256, RS384, ES384, ES512 was specified as the JWT signing
algorithm they would generate RS512 and ES256 respectively.
- Added unit test.
2024-11-16 15:17:19 +01:00
silverwind
308812a82e
Fix mermaid diagram height when initially hidden ( #32457 )
...
In a hidden iframe, `document.body.clientHeight` is not reliable. Use
`IntersectionObserver` to detect the visibility change and update the
height there.
Fixes: https://github.com/go-gitea/gitea/issues/32392
<img width="885" alt="image"
src="https://github.com/user-attachments/assets/a95ef6aa-27e7-443f-9d06-400ef27919ae ">
(cherry picked from commit b55a31eb6a894feb5508e350ff5e9548b2531bd6)
2024-11-16 15:12:25 +01:00
Zettat123
fc26becba4
Fix broken releases when re-pushing tags ( #32435 )
...
Fix #32427
(cherry picked from commit 35bcd667b23de29a7b0d0bf1090fb10961d3aca3)
Conflicts:
- tests/integration/repo_tag_test.go
Resolved by manually copying the added test, and also manually
adjusting the imported Go modules.
2024-11-16 15:12:25 +01:00
Gusted
02a2dbef69
feat: default to generating EdDSA for OAuth JWT signing key
2024-11-16 15:03:28 +01:00
Lunny Xiao
013cc1dee4
Only query team tables if repository is under org when getting assignees ( #32414 )
...
It's unnecessary to query the team table if the repository is not under
organization when getting assignees.
(cherry picked from commit 1887c75c35c1d16372b1dbe2b792e374b558ce1f)
2024-11-16 14:57:11 +01:00
Gusted
6d0f2c1b82
Merge pull request 'Update module google.golang.org/grpc to v1.68.0 (forgejo)' ( #5969 ) from renovate/forgejo-google.golang.org-grpc-1.x into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/5969
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
2024-11-16 12:25:41 +00:00
Gusted
2cccc02e76
feat: improve GetLatestCommitStatusForPairs
...
- Simplify the function into a single SQL query. This may or may not
help with a monster query we are seeing in Codeberg that is using 400MiB
and takes 50MiB to simply log the query. The result is now capped to the
actual latest index,
- Add unit test.
2024-11-16 13:23:40 +01:00
Earl Warren
356aa6521b
Merge pull request 'fix: extend forgejo_auth_token
table (part two)' ( #5984 ) from earl-warren/forgejo:wip-forgejo-auth-token into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/5984
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
2024-11-16 11:56:02 +00:00
Earl Warren
cf323a3d55
fix: extend forgejo_auth_token
table (part two)
...
Add the default value of the purpose field to both the table and the
migration. The table in v9 and v7 backport already have the default
value.
ALTER TABLE `forgejo_auth_token` ADD `purpose` TEXT NOT NULL [] - Cannot add a NOT NULL column with default value NULL
2024-11-16 10:53:46 +01:00
Gusted
6bab3c374c
Merge pull request 'Update github.com/grafana/go-json digest to f14426c (forgejo)' ( #5980 ) from renovate/forgejo-github.com-grafana-go-json-digest into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/5980
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
2024-11-16 03:07:17 +00:00
Gusted
570e8cec9e
Merge pull request 'Update dependency tailwindcss to v3.4.15 (forgejo)' ( #5966 ) from renovate/forgejo-tailwindcss-3.x into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/5966
Reviewed-by: Michael Kriese <michael.kriese@gmx.de>
2024-11-16 02:23:37 +00:00
Michael Kriese
bf810fa8d3
Merge pull request 'ci: upload all e2e artifacts' ( #5973 ) from viceice/ci/e2e-artifacts into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/5973
2024-11-16 00:34:34 +00:00
Renovate Bot
66dfb2813c
Update github.com/grafana/go-json digest to f14426c
2024-11-16 00:03:23 +00:00
Earl Warren
95a8987844
Merge pull request 'chore(release-notes): fix the v9.0.2 links' ( #5978 ) from earl-warren/forgejo:wip-release-notes into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/5978
Reviewed-by: Michael Kriese <michael.kriese@gmx.de>
2024-11-15 22:48:55 +00:00
Earl Warren
9fd2df6e30
chore(release-notes): fix the v9.0.2 links
2024-11-15 22:59:52 +01:00
Michael Kriese
7f707b2a6f
ci: disable postgresql fsync
2024-11-15 15:29:06 +01:00