diff --git a/routers/web/repo/actions/actions.go b/routers/web/repo/actions/actions.go index 1a7ccbb82c..58f1fde607 100644 --- a/routers/web/repo/actions/actions.go +++ b/routers/web/repo/actions/actions.go @@ -68,198 +68,7 @@ func List(ctx *context.Context) { curWorkflow := ctx.FormString("workflow") ctx.Data["CurWorkflow"] = curWorkflow - var workflows []Workflow - if empty, err := ctx.Repo.GitRepo.IsEmpty(); err != nil { - ctx.ServerError("IsEmpty", err) - return - } else if !empty { - commit, err := ctx.Repo.GitRepo.GetBranchCommit(ctx.Repo.Repository.DefaultBranch) - if err != nil { - ctx.ServerError("GetBranchCommit", err) - return - } - entries, err := actions.ListWorkflows(commit) - if err != nil { - ctx.ServerError("ListWorkflows", err) - return - } - - // Get all runner labels - runners, err := db.Find[actions_model.ActionRunner](ctx, actions_model.FindRunnerOptions{ - RepoID: ctx.Repo.Repository.ID, - IsOnline: optional.Some(true), - WithAvailable: true, - }) - if err != nil { - ctx.ServerError("FindRunners", err) - return - } - allRunnerLabels := make(container.Set[string]) - for _, r := range runners { - allRunnerLabels.AddMultiple(r.AgentLabels...) - } - - canRun := ctx.Repo.CanWrite(unit.TypeActions) - - workflows = make([]Workflow, 0, len(entries)) - for _, entry := range entries { - workflow := Workflow{Entry: *entry} - content, err := actions.GetContentFromEntry(entry) - if err != nil { - ctx.ServerError("GetContentFromEntry", err) - return - } - wf, err := model.ReadWorkflow(bytes.NewReader(content)) - if err != nil { - workflow.ErrMsg = ctx.Locale.TrString("actions.runs.invalid_workflow_helper", err.Error()) - workflows = append(workflows, workflow) - continue - } - // The workflow must contain at least one job without "needs". Otherwise, a deadlock will occur and no jobs will be able to run. - hasJobWithoutNeeds := false - // Check whether have matching runner and a job without "needs" - emptyJobsNumber := 0 - for _, j := range wf.Jobs { - if j == nil { - emptyJobsNumber++ - continue - } - if !hasJobWithoutNeeds && len(j.Needs()) == 0 { - hasJobWithoutNeeds = true - } - runsOnList := j.RunsOn() - for _, ro := range runsOnList { - if strings.Contains(ro, "${{") { - // Skip if it contains expressions. - // The expressions could be very complex and could not be evaluated here, - // so just skip it, it's OK since it's just a tooltip message. - continue - } - if !allRunnerLabels.Contains(ro) { - workflow.ErrMsg = ctx.Locale.TrString("actions.runs.no_matching_online_runner_helper", ro) - break - } - } - if workflow.ErrMsg != "" { - break - } - } - if !hasJobWithoutNeeds { - workflow.ErrMsg = ctx.Locale.TrString("actions.runs.no_job_without_needs") - } - if emptyJobsNumber == len(wf.Jobs) { - workflow.ErrMsg = ctx.Locale.TrString("actions.runs.no_job") - } - workflows = append(workflows, workflow) - - if canRun && workflow.Entry.Name() == curWorkflow { - config := wf.WorkflowDispatchConfig() - if config != nil { - keys := util.KeysOfMap(config.Inputs) - slices.Sort(keys) - if int64(len(config.Inputs)) > setting.Actions.LimitDispatchInputs { - keys = keys[:setting.Actions.LimitDispatchInputs] - } - - ctx.Data["CurWorkflowDispatch"] = config - ctx.Data["CurWorkflowDispatchInputKeys"] = keys - ctx.Data["WarnDispatchInputsLimit"] = int64(len(config.Inputs)) > setting.Actions.LimitDispatchInputs - ctx.Data["DispatchInputsLimit"] = setting.Actions.LimitDispatchInputs - } - } - } - } - ctx.Data["workflows"] = workflows - ctx.Data["RepoLink"] = ctx.Repo.Repository.Link() - - page := ctx.FormInt("page") - if page <= 0 { - page = 1 - } - - actorID := ctx.FormInt64("actor") - status := ctx.FormInt("status") - - actionsConfig := ctx.Repo.Repository.MustGetUnit(ctx, unit.TypeActions).ActionsConfig() - ctx.Data["ActionsConfig"] = actionsConfig - - if len(curWorkflow) > 0 && ctx.Repo.IsAdmin() { - ctx.Data["AllowDisableOrEnableWorkflow"] = true - ctx.Data["CurWorkflowDisabled"] = actionsConfig.IsWorkflowDisabled(curWorkflow) - } - - // if status or actor query param is not given to frontend href, (href="//actions") - // they will be 0 by default, which indicates get all status or actors - ctx.Data["CurActor"] = actorID - ctx.Data["CurStatus"] = status - if actorID > 0 || status > int(actions_model.StatusUnknown) { - ctx.Data["IsFiltered"] = true - } - - opts := actions_model.FindRunOptions{ - ListOptions: db.ListOptions{ - Page: page, - PageSize: convert.ToCorrectPageSize(ctx.FormInt("limit")), - }, - RepoID: ctx.Repo.Repository.ID, - WorkflowID: curWorkflow, - TriggerUserID: actorID, - } - - // if status is not StatusUnknown, it means user has selected a status filter - if actions_model.Status(status) != actions_model.StatusUnknown { - opts.Status = []actions_model.Status{actions_model.Status(status)} - } - - runs, total, err := db.FindAndCount[actions_model.ActionRun](ctx, opts) - if err != nil { - ctx.ServerError("FindAndCount", err) - return - } - - for _, run := range runs { - run.Repo = ctx.Repo.Repository - } - - if err := actions_model.RunList(runs).LoadTriggerUser(ctx); err != nil { - ctx.ServerError("LoadTriggerUser", err) - return - } - - if err := loadIsRefDeleted(ctx, ctx.Repo.Repository.ID, runs); err != nil { - log.Error("LoadIsRefDeleted", err) - } - - ctx.Data["Runs"] = runs - - ctx.Data["Repo"] = ctx.Repo - - actors, err := actions_model.GetActors(ctx, ctx.Repo.Repository.ID) - if err != nil { - ctx.ServerError("GetActors", err) - return - } - ctx.Data["Actors"] = repo.MakeSelfOnTop(ctx.Doer, actors) - - ctx.Data["StatusInfoList"] = actions_model.GetStatusInfoList(ctx, ctx.Locale) - - pager := context.NewPagination(int(total), opts.PageSize, opts.Page, 5) - pager.SetDefaultParams(ctx) - pager.AddParamString("workflow", curWorkflow) - pager.AddParamString("actor", fmt.Sprint(actorID)) - pager.AddParamString("status", fmt.Sprint(status)) - ctx.Data["Page"] = pager - ctx.Data["HasWorkflowsOrRuns"] = len(workflows) > 0 || len(runs) > 0 - - ctx.HTML(http.StatusOK, tplListActions) -} - -func ListInner(ctx *context.Context) { - ctx.Data["Title"] = ctx.Tr("actions.actions") - ctx.Data["PageIsActions"] = true - - curWorkflow := ctx.FormString("workflow") - ctx.Data["CurWorkflow"] = curWorkflow + listOnly := ctx.FormBool("listonly") var workflows []Workflow if empty, err := ctx.Repo.GitRepo.IsEmpty(); err != nil { @@ -444,7 +253,11 @@ func ListInner(ctx *context.Context) { ctx.Data["Page"] = pager ctx.Data["HasWorkflowsOrRuns"] = len(workflows) > 0 || len(runs) > 0 - ctx.HTML(http.StatusOK, tplListActionsInner) + if listOnly { + ctx.HTML(http.StatusOK, tplListActionsInner) + } else { + ctx.HTML(http.StatusOK, tplListActions) + } } // loadIsRefDeleted loads the IsRefDeleted field for each run in the list. diff --git a/routers/web/web.go b/routers/web/web.go index b68c0093fc..58aa5d8766 100644 --- a/routers/web/web.go +++ b/routers/web/web.go @@ -1391,7 +1391,6 @@ func registerRoutes(m *web.Route) { m.Group("/actions", func() { m.Get("", actions.List) - m.Get("/inner", actions.ListInner) m.Post("/disable", reqRepoAdmin, actions.DisableWorkflowFile) m.Post("/enable", reqRepoAdmin, actions.EnableWorkflowFile) m.Post("/manual", reqRepoAdmin, actions.ManualRunWorkflow) diff --git a/templates/repo/actions/list.tmpl b/templates/repo/actions/list.tmpl index 9fe79d102a..9d19d2993e 100644 --- a/templates/repo/actions/list.tmpl +++ b/templates/repo/actions/list.tmpl @@ -4,14 +4,13 @@
{{template "base/alert" .}} -
- {{/* Refresh the list every interval (15s) unless the document isn't visible or a dropdown is open; refresh + {{/* Refresh the list every interval (30s) unless the document isn't visible or a dropdown is open; refresh if visibility changes as well. */}}
+ hx-trigger="every 30s [document.visibilityState === 'visible' && noActiveDropdowns()], visibilitychange[document.visibilityState === 'visible'] from:document" + hx-indicator="#reloading-indicator"> {{template "repo/actions/list_inner" .}}
diff --git a/templates/repo/actions/list_inner.tmpl b/templates/repo/actions/list_inner.tmpl index 22e3346429..393411fac7 100644 --- a/templates/repo/actions/list_inner.tmpl +++ b/templates/repo/actions/list_inner.tmpl @@ -20,6 +20,8 @@