enable linter testifylint on v8 (#4573)

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4573
Co-authored-by: TheFox0x7 <thefox0x7@gmail.com>
Co-committed-by: TheFox0x7 <thefox0x7@gmail.com>
This commit is contained in:
TheFox0x7 2024-07-30 19:41:27 +00:00 committed by Earl Warren
parent 4d2263e82e
commit ce563ade3d
503 changed files with 5014 additions and 4665 deletions

View file

@ -12,6 +12,7 @@ import (
"code.gitea.io/gitea/modules/test"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
)
func createTestCache() {
@ -23,7 +24,7 @@ func createTestCache() {
}
func TestNewContext(t *testing.T) {
assert.NoError(t, Init())
require.NoError(t, Init())
setting.CacheService.Cache = setting.Cache{Adapter: "redis", Conn: "some random string"}
con, err := newCache(setting.Cache{
@ -31,18 +32,18 @@ func TestNewContext(t *testing.T) {
Conn: "false conf",
Interval: 100,
})
assert.Error(t, err)
require.Error(t, err)
assert.Nil(t, con)
}
func TestTest(t *testing.T) {
defer test.MockVariableValue(&conn, nil)()
_, err := Test()
assert.Error(t, err)
require.Error(t, err)
createTestCache()
elapsed, err := Test()
assert.NoError(t, err)
require.NoError(t, err)
// mem cache should take from 300ns up to 1ms on modern hardware ...
assert.Less(t, elapsed, SlowCacheThreshold)
}
@ -59,32 +60,32 @@ func TestGetString(t *testing.T) {
data, err := GetString("key", func() (string, error) {
return "", fmt.Errorf("some error")
})
assert.Error(t, err)
require.Error(t, err)
assert.Equal(t, "", data)
data, err = GetString("key", func() (string, error) {
return "", nil
})
assert.NoError(t, err)
require.NoError(t, err)
assert.Equal(t, "", data)
data, err = GetString("key", func() (string, error) {
return "some data", nil
})
assert.NoError(t, err)
require.NoError(t, err)
assert.Equal(t, "", data)
Remove("key")
data, err = GetString("key", func() (string, error) {
return "some data", nil
})
assert.NoError(t, err)
require.NoError(t, err)
assert.Equal(t, "some data", data)
data, err = GetString("key", func() (string, error) {
return "", fmt.Errorf("some error")
})
assert.NoError(t, err)
require.NoError(t, err)
assert.Equal(t, "some data", data)
Remove("key")
}
@ -95,32 +96,32 @@ func TestGetInt(t *testing.T) {
data, err := GetInt("key", func() (int, error) {
return 0, fmt.Errorf("some error")
})
assert.Error(t, err)
require.Error(t, err)
assert.Equal(t, 0, data)
data, err = GetInt("key", func() (int, error) {
return 0, nil
})
assert.NoError(t, err)
require.NoError(t, err)
assert.Equal(t, 0, data)
data, err = GetInt("key", func() (int, error) {
return 100, nil
})
assert.NoError(t, err)
require.NoError(t, err)
assert.Equal(t, 0, data)
Remove("key")
data, err = GetInt("key", func() (int, error) {
return 100, nil
})
assert.NoError(t, err)
require.NoError(t, err)
assert.Equal(t, 100, data)
data, err = GetInt("key", func() (int, error) {
return 0, fmt.Errorf("some error")
})
assert.NoError(t, err)
require.NoError(t, err)
assert.Equal(t, 100, data)
Remove("key")
}
@ -131,32 +132,32 @@ func TestGetInt64(t *testing.T) {
data, err := GetInt64("key", func() (int64, error) {
return 0, fmt.Errorf("some error")
})
assert.Error(t, err)
require.Error(t, err)
assert.EqualValues(t, 0, data)
data, err = GetInt64("key", func() (int64, error) {
return 0, nil
})
assert.NoError(t, err)
require.NoError(t, err)
assert.EqualValues(t, 0, data)
data, err = GetInt64("key", func() (int64, error) {
return 100, nil
})
assert.NoError(t, err)
require.NoError(t, err)
assert.EqualValues(t, 0, data)
Remove("key")
data, err = GetInt64("key", func() (int64, error) {
return 100, nil
})
assert.NoError(t, err)
require.NoError(t, err)
assert.EqualValues(t, 100, data)
data, err = GetInt64("key", func() (int64, error) {
return 0, fmt.Errorf("some error")
})
assert.NoError(t, err)
require.NoError(t, err)
assert.EqualValues(t, 100, data)
Remove("key")
}