From b085ce37a6acc4ed25e6929c3a765ca5f8a92b69 Mon Sep 17 00:00:00 2001 From: erik Date: Wed, 15 Nov 2023 08:53:02 +0100 Subject: [PATCH] Review --- modules/forgefed/star.go | 5 ++--- routers/api/v1/api.go | 4 ++-- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/modules/forgefed/star.go b/modules/forgefed/star.go index a5ce28ce72..3e6843e0f9 100644 --- a/modules/forgefed/star.go +++ b/modules/forgefed/star.go @@ -30,19 +30,18 @@ var KnownSourceTypes = SourceTypes{ // swagger:model type Star struct { // swagger:ignore - Activity ap.Activity + ap.Activity // Source identifies the system which generated this activity. Exactly one value has to be specified. Source SourceType `jsonld:"source,omitempty"` } // StarNew initializes a Star type activity -func StarNew(id ap.ID, ob ap.ID) *Star { // ToDo: Currently this function is not used anywhere, so we don't create stars? +func StarNew(id ap.ID, ob ap.ID) *Star { // ToDo: May be used later in creating signed activities a := ap.ActivityNew(id, StarType, ob) o := Star{Activity: *a, Source: ForgejoSourceType} return &o } -// ToDo: should Star be *Star? func (a Star) MarshalJSON() ([]byte, error) { b := make([]byte, 0) ap.JSONWrite(&b, '{') diff --git a/routers/api/v1/api.go b/routers/api/v1/api.go index 7d29076204..3ef5d89b86 100644 --- a/routers/api/v1/api.go +++ b/routers/api/v1/api.go @@ -897,11 +897,11 @@ func Routes() *web.Route { }, context_service.UserIDAssignmentAPI()) m.Group("/repository-id/{repository-id}", func() { m.Get("", activitypub.Repository) - m.Post("/inbox", // ToDo: We may want a m.Patch method here, as we are not replacing stars + m.Post("/inbox", // ToDo: Post or Put? // TODO: bind ativities here bind(forgefed.Star{}), //activitypub.ReqHTTPSignature(), - activitypub.RepositoryInbox) // ToDo: We may need to use another method to add a star to the repo + activitypub.RepositoryInbox) }, context_service.RepositoryIDAssignmentAPI()) }, tokenRequiresScopes(auth_model.AccessTokenScopeCategoryActivityPub)) }