style: reenable switch check

This commit is contained in:
TheFox0x7 2024-07-17 19:19:36 +02:00
parent adf4dcdbbf
commit 8322882265
No known key found for this signature in database
GPG key ID: 6CA33903484AF7C2
19 changed files with 29 additions and 43 deletions

View file

@ -43,7 +43,6 @@ linters-settings:
gocritic: gocritic:
disabled-checks: disabled-checks:
- ifElseChain - ifElseChain
- singleCaseSwitch # Every time this occurred in the code, there was no other way.
revive: revive:
severity: error severity: error
rules: rules:

View file

@ -58,6 +58,7 @@ func Cell2Int64(val xorm.Cell) int64 {
v, _ := strconv.ParseInt(string((*val).([]uint8)), 10, 64) v, _ := strconv.ParseInt(string((*val).([]uint8)), 10, 64)
return v return v
default:
return (*val).(int64)
} }
return (*val).(int64)
} }

View file

@ -235,8 +235,7 @@ func (cfg *ActionsConfig) ToDB() ([]byte, error) {
// BeforeSet is invoked from XORM before setting the value of a field of this object. // BeforeSet is invoked from XORM before setting the value of a field of this object.
func (r *RepoUnit) BeforeSet(colName string, val xorm.Cell) { func (r *RepoUnit) BeforeSet(colName string, val xorm.Cell) {
switch colName { if colName == "type" {
case "type":
switch unit.Type(db.Cell2Int64(val)) { switch unit.Type(db.Cell2Int64(val)) {
case unit.TypeExternalWiki: case unit.TypeExternalWiki:
r.Config = new(ExternalWikiConfig) r.Config = new(ExternalWikiConfig)

View file

@ -649,8 +649,7 @@ func matchReleaseEvent(payload *api.ReleasePayload, evt *jobparser.Event) bool {
// unpublished, created, deleted, prereleased, released // unpublished, created, deleted, prereleased, released
action := payload.Action action := payload.Action
switch action { if action == api.HookReleaseUpdated {
case api.HookReleaseUpdated:
action = "edited" action = "edited"
} }
for _, val := range vals { for _, val := range vals {
@ -686,8 +685,7 @@ func matchPackageEvent(payload *api.PackagePayload, evt *jobparser.Event) bool {
// updated // updated
action := payload.Action action := payload.Action
switch action { if action == api.HookPackageCreated {
case api.HookPackageCreated:
action = "published" action = "published"
} }
for _, val := range vals { for _, val := range vals {

View file

@ -16,8 +16,9 @@ func GetItemByType(typ ap.ActivityVocabularyType) (ap.Item, error) {
switch typ { switch typ {
case RepositoryType: case RepositoryType:
return RepositoryNew(""), nil return RepositoryNew(""), nil
default:
return ap.GetItemByType(typ)
} }
return ap.GetItemByType(typ)
} }
// JSONUnmarshalerFn is the function that will load the data from a fastjson.Value into an Item // JSONUnmarshalerFn is the function that will load the data from a fastjson.Value into an Item
@ -28,8 +29,9 @@ func JSONUnmarshalerFn(typ ap.ActivityVocabularyType, val *fastjson.Value, i ap.
return OnRepository(i, func(r *Repository) error { return OnRepository(i, func(r *Repository) error {
return JSONLoadRepository(val, r) return JSONLoadRepository(val, r)
}) })
default:
return nil
} }
return nil
} }
// NotEmpty is the function that checks if an object is empty // NotEmpty is the function that checks if an object is empty
@ -44,6 +46,7 @@ func NotEmpty(i ap.Item) bool {
return false return false
} }
return ap.NotEmpty(r.Actor) return ap.NotEmpty(r.Actor)
default:
return ap.NotEmpty(i)
} }
return ap.NotEmpty(i)
} }

View file

@ -34,8 +34,7 @@ func (g *GitHubCalloutTransformer) Transform(node *ast.Document, reader text.Rea
return ast.WalkContinue, nil return ast.WalkContinue, nil
} }
switch v := n.(type) { if v, ok := n.(*ast.Blockquote); ok {
case *ast.Blockquote:
if v.ChildCount() == 0 { if v.ChildCount() == 0 {
return ast.WalkContinue, nil return ast.WalkContinue, nil
} }
@ -91,7 +90,6 @@ func (g *GitHubCalloutTransformer) Transform(node *ast.Document, reader text.Rea
firstParagraph.Parent().InsertBefore(firstParagraph.Parent(), firstParagraph, attentionParagraph) firstParagraph.Parent().InsertBefore(firstParagraph.Parent(), firstParagraph, attentionParagraph)
firstParagraph.RemoveChild(firstParagraph, firstTextNode) firstParagraph.RemoveChild(firstParagraph, firstTextNode)
firstParagraph.RemoveChild(firstParagraph, secondTextNode) firstParagraph.RemoveChild(firstParagraph, secondTextNode)
firstParagraph.RemoveChild(firstParagraph, thirdTextNode)
} }
return ast.WalkContinue, nil return ast.WalkContinue, nil
}) })

View file

@ -23,8 +23,7 @@ func (g *GitHubLegacyCalloutTransformer) Transform(node *ast.Document, reader te
return ast.WalkContinue, nil return ast.WalkContinue, nil
} }
switch v := n.(type) { if v, ok := n.(*ast.Blockquote); ok {
case *ast.Blockquote:
if v.ChildCount() == 0 { if v.ChildCount() == 0 {
return ast.WalkContinue, nil return ast.WalkContinue, nil
} }

View file

@ -98,8 +98,7 @@ func getLicensePlaceholder(name string) *licensePlaceholder {
// Some special placeholders for specific licenses. // Some special placeholders for specific licenses.
// It's unsafe to apply them to all licenses. // It's unsafe to apply them to all licenses.
switch name { if name == "0BSD" {
case "0BSD":
return &licensePlaceholder{ return &licensePlaceholder{
Owner: []string{"AUTHOR"}, Owner: []string{"AUTHOR"},
Email: []string{"EMAIL"}, Email: []string{"EMAIL"},

View file

@ -122,8 +122,7 @@ func (p *RedisProvider) Init(maxlifetime int64, configs string) (err error) {
uri := nosql.ToRedisURI(configs) uri := nosql.ToRedisURI(configs)
for k, v := range uri.Query() { for k, v := range uri.Query() {
switch k { if k == "prefix" {
case "prefix":
p.prefix = v[0] p.prefix = v[0]
} }
} }

View file

@ -13,8 +13,9 @@ func (taskType TaskType) Name() string {
switch taskType { switch taskType {
case TaskTypeMigrateRepo: case TaskTypeMigrateRepo:
return "Migrate Repository" return "Migrate Repository"
default:
return ""
} }
return ""
} }
// TaskStatus defines task status // TaskStatus defines task status

View file

@ -83,12 +83,9 @@ func (entry *Workflow) Dispatch(ctx context.Context, inputGetter InputValueGette
} }
continue continue
} }
} else { } else if input.Type == "boolean" {
switch input.Type { // Since "boolean" inputs are rendered as a checkbox in html, the value inside the form is "on"
case "boolean": val = strconv.FormatBool(val == "on")
// Since "boolean" inputs are rendered as a checkbox in html, the value inside the form is "on"
val = strconv.FormatBool(val == "on")
}
} }
inputs[key] = val inputs[key] = val
} }

View file

@ -181,7 +181,7 @@ func (h *UnsubscribeHandler) Handle(ctx context.Context, _ *MailContent, doer *u
} }
return issues_model.CreateOrUpdateIssueWatch(ctx, doer.ID, issue.ID, false) return issues_model.CreateOrUpdateIssueWatch(ctx, doer.ID, issue.ID, false)
default:
return fmt.Errorf("unsupported unsubscribe reference: %v", ref)
} }
return fmt.Errorf("unsupported unsubscribe reference: %v", ref)
} }

View file

@ -160,8 +160,7 @@ func (dc dingtalkConvertor) PullRequest(p *api.PullRequestPayload) (DingtalkPayl
// Review implements PayloadConvertor Review method // Review implements PayloadConvertor Review method
func (dc dingtalkConvertor) Review(p *api.PullRequestPayload, event webhook_module.HookEventType) (DingtalkPayload, error) { func (dc dingtalkConvertor) Review(p *api.PullRequestPayload, event webhook_module.HookEventType) (DingtalkPayload, error) {
var text, title string var text, title string
switch p.Action { if p.Action == api.HookIssueReviewed {
case api.HookIssueReviewed:
action, err := parseHookPullRequestEventType(event) action, err := parseHookPullRequestEventType(event)
if err != nil { if err != nil {
return DingtalkPayload{}, err return DingtalkPayload{}, err

View file

@ -215,8 +215,7 @@ func (d discordConvertor) PullRequest(p *api.PullRequestPayload) (DiscordPayload
func (d discordConvertor) Review(p *api.PullRequestPayload, event webhook_module.HookEventType) (DiscordPayload, error) { func (d discordConvertor) Review(p *api.PullRequestPayload, event webhook_module.HookEventType) (DiscordPayload, error) {
var text, title string var text, title string
var color int var color int
switch p.Action { if p.Action == api.HookIssueReviewed {
case api.HookIssueReviewed:
action, err := parseHookPullRequestEventType(event) action, err := parseHookPullRequestEventType(event)
if err != nil { if err != nil {
return DiscordPayload{}, err return DiscordPayload{}, err

View file

@ -237,8 +237,7 @@ func (m matrixConvertor) Review(p *api.PullRequestPayload, event webhook_module.
repoLink := htmlLinkFormatter(p.Repository.HTMLURL, p.Repository.FullName) repoLink := htmlLinkFormatter(p.Repository.HTMLURL, p.Repository.FullName)
var text string var text string
switch p.Action { if p.Action == api.HookIssueReviewed {
case api.HookIssueReviewed:
action, err := parseHookPullRequestEventType(event) action, err := parseHookPullRequestEventType(event)
if err != nil { if err != nil {
return MatrixPayload{}, err return MatrixPayload{}, err

View file

@ -225,8 +225,7 @@ func (m msteamsConvertor) PullRequest(p *api.PullRequestPayload) (MSTeamsPayload
func (m msteamsConvertor) Review(p *api.PullRequestPayload, event webhook_module.HookEventType) (MSTeamsPayload, error) { func (m msteamsConvertor) Review(p *api.PullRequestPayload, event webhook_module.HookEventType) (MSTeamsPayload, error) {
var text, title string var text, title string
var color int var color int
switch p.Action { if p.Action == api.HookIssueReviewed {
case api.HookIssueReviewed:
action, err := parseHookPullRequestEventType(event) action, err := parseHookPullRequestEventType(event)
if err != nil { if err != nil {
return MSTeamsPayload{}, err return MSTeamsPayload{}, err

View file

@ -289,8 +289,7 @@ func (s slackConvertor) Review(p *api.PullRequestPayload, event webhook_module.H
repoLink := SlackLinkFormatter(p.Repository.HTMLURL, p.Repository.FullName) repoLink := SlackLinkFormatter(p.Repository.HTMLURL, p.Repository.FullName)
var text string var text string
switch p.Action { if p.Action == api.HookIssueReviewed {
case api.HookIssueReviewed:
action, err := parseHookPullRequestEventType(event) action, err := parseHookPullRequestEventType(event)
if err != nil { if err != nil {
return SlackPayload{}, err return SlackPayload{}, err

View file

@ -164,8 +164,7 @@ func (t telegramConvertor) PullRequest(p *api.PullRequestPayload) (TelegramPaylo
// Review implements PayloadConvertor Review method // Review implements PayloadConvertor Review method
func (t telegramConvertor) Review(p *api.PullRequestPayload, event webhook_module.HookEventType) (TelegramPayload, error) { func (t telegramConvertor) Review(p *api.PullRequestPayload, event webhook_module.HookEventType) (TelegramPayload, error) {
var text, attachmentText string var text, attachmentText string
switch p.Action { if p.Action == api.HookIssueReviewed {
case api.HookIssueReviewed:
action, err := parseHookPullRequestEventType(event) action, err := parseHookPullRequestEventType(event)
if err != nil { if err != nil {
return TelegramPayload{}, err return TelegramPayload{}, err

View file

@ -154,8 +154,7 @@ func (wc wechatworkConvertor) PullRequest(p *api.PullRequestPayload) (Wechatwork
// Review implements PayloadConvertor Review method // Review implements PayloadConvertor Review method
func (wc wechatworkConvertor) Review(p *api.PullRequestPayload, event webhook_module.HookEventType) (WechatworkPayload, error) { func (wc wechatworkConvertor) Review(p *api.PullRequestPayload, event webhook_module.HookEventType) (WechatworkPayload, error) {
var text, title string var text, title string
switch p.Action { if p.Action == api.HookIssueReviewed {
case api.HookIssueReviewed:
action, err := parseHookPullRequestEventType(event) action, err := parseHookPullRequestEventType(event)
if err != nil { if err != nil {
return WechatworkPayload{}, err return WechatworkPayload{}, err