From 624a6e83329a4a7bf8c46ea6e0903b9d9d7c8470 Mon Sep 17 00:00:00 2001 From: f Date: Mon, 17 Mar 2025 17:48:26 -0300 Subject: [PATCH] fix: return after error --- routers/api/packages/rubygems/rubygems.go | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/routers/api/packages/rubygems/rubygems.go b/routers/api/packages/rubygems/rubygems.go index ed7bcc9fd9..770960ddd6 100644 --- a/routers/api/packages/rubygems/rubygems.go +++ b/routers/api/packages/rubygems/rubygems.go @@ -105,9 +105,11 @@ func ServePackageInfo(ctx *context.Context) { ctx, ctx.Package.Owner.ID, packages_model.TypeRubyGems, packageName) if err != nil { apiError(ctx, http.StatusInternalServerError, err) + return } if len(versions) == 0 { apiError(ctx, http.StatusNotFound, fmt.Sprintf("Could not find package %s", packageName)) + return } result, err := buildInfoFileForPackage(ctx, versions) @@ -135,6 +137,7 @@ func ServeVersionsFile(ctx *context.Context) { ctx, ctx.Package.Owner.ID, packages_model.TypeRubyGems, pack.Name) if err != nil { apiError(ctx, http.StatusInternalServerError, err) + return } if len(versions) == 0 { // No versions left for this package, we should continue. @@ -148,6 +151,7 @@ func ServeVersionsFile(ctx *context.Context) { pd, err := packages_model.GetPackageDescriptor(ctx, v) if err != nil { apiError(ctx, http.StatusInternalServerError, err) + return } metadata := pd.Metadata.(*rubygems_module.Metadata) @@ -165,6 +169,7 @@ func ServeVersionsFile(ctx *context.Context) { info, err := buildInfoFileForPackage(ctx, versions) if err != nil { apiError(ctx, http.StatusInternalServerError, err) + return } checksum := md5.Sum([]byte(*info))