ui: improve error pages (#7274)

* add testing
* make each page accessible via `/devtest/error`
* allow translating the `Page not found` part of the title
* code: improve consistency, remove unused
* devtest: put index page in a container to fix alignment
* 500: make navbar more like the real one, remove fake menu button
* deadcode: remove unused `func NotFound`: it was added in bdd32f152d and the only usage was removed in 1bfb0a24d8

Preview:
https://codeberg.org/attachments/1b75afb3-e898-410f-be02-f036a5400143

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/7274
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
Reviewed-by: Beowulf <beowulf@beocode.eu>
This commit is contained in:
0ko 2025-03-28 19:50:43 +00:00
parent 683eb5bf78
commit 51ff4970ec
11 changed files with 106 additions and 32 deletions

View file

@ -1,9 +1,11 @@
// Copyright 2023 The Gitea Authors. All rights reserved.
// Copyright 2025 The Forgejo Authors. All rights reserved.
// SPDX-License-Identifier: MIT
package devtest
import (
"errors"
"net/http"
"path"
"strings"
@ -42,6 +44,17 @@ func FetchActionTest(ctx *context.Context) {
ctx.JSONRedirect("")
}
func ErrorPage(ctx *context.Context) {
if ctx.Params("errcode") == "404" {
ctx.NotFound("Example error", errors.New("Example error"))
return
} else if ctx.Params("errcode") == "413" {
ctx.HTML(http.StatusRequestEntityTooLarge, base.TplName("status/413"))
return
}
ctx.ServerError("Example error", errors.New("Example error"))
}
func Tmpl(ctx *context.Context) {
now := time.Now()
ctx.Data["TimeNow"] = now