mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2025-05-17 04:19:29 +02:00
feat(i18n): Branch protection improvements
- adds a header to indicate creating a new rule - test that header is different between new and edit form - consistently avoids colons in the form - excludes some accessibility checks that require a global solution for forms
This commit is contained in:
parent
3bbd129270
commit
00276dfc30
4 changed files with 40 additions and 13 deletions
|
@ -4,9 +4,13 @@ import AxeBuilder from '@axe-core/playwright';
|
|||
export async function validate_form({page}, scope) {
|
||||
scope ??= 'form';
|
||||
const accessibilityScanResults = await new AxeBuilder({page})
|
||||
// disable checking for link style - should be fixed, but not now
|
||||
.disableRules('link-in-text-block')
|
||||
.include(scope)
|
||||
// exclude automated tooltips from accessibility scan, remove when fixed
|
||||
.exclude('span[data-tooltip-content')
|
||||
// exclude weird non-semantic HTML disabled content
|
||||
.exclude('.disabled')
|
||||
.analyze();
|
||||
expect(accessibilityScanResults.violations).toEqual([]);
|
||||
|
||||
|
@ -17,4 +21,10 @@ export async function validate_form({page}, scope) {
|
|||
await expect(b).toHaveCSS('margin-top', '0px');
|
||||
await expect(b).toHaveCSS('vertical-align', 'baseline');
|
||||
}
|
||||
// assert no (trailing) colon is used in labels
|
||||
// might be necessary to adjust in case colons are strictly necessary in help text
|
||||
for (const l of await page.locator('label').all()) {
|
||||
const str = await l.textContent();
|
||||
await expect(str.split('\n')[0]).not.toContain(':');
|
||||
}
|
||||
}
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue